Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing paths-ignore from action to avoid blocking releases #69

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

chanind
Copy link
Collaborator

@chanind chanind commented Apr 6, 2024

This PR removes the paths-ignore key from the build workflow, as this may unintentionally block releases from running. Semantic-release will fail if when it comes time to publish a relase, the published commit is no longer the head commit in the repo. This is to avoid situations where an earlier commit might get a later version number than later commit if they both are merged at roughly the same time.

However, if the most recent commit is just a change to the README.md for example, the paths-ignore can cause semantic-release to fail. If, due to the README.md change, it is no longer the most recent commit to the repo, semantic release will bail out assuming that the most recent CI run will pull in the changes and publish, but due to the paths-ignore, CI never gets run and thus the change never gets deployed.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (a13cee3) to head (28ff797).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files          15       15           
  Lines        1272     1272           
  Branches      198      198           
=======================================
  Hits          702      702           
  Misses        530      530           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbloomAus jbloomAus merged commit 179cea1 into jbloomAus:main Apr 6, 2024
6 checks passed
@chanind chanind deleted the remove-ci-ignore branch April 6, 2024 15:50
tom-pollak pushed a commit to tom-pollak/SAELens that referenced this pull request Oct 22, 2024
fix: removing paths-ignore from action to avoid blocking releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants