Skip to content

Commit

Permalink
Do not generate service file for LogManager
Browse files Browse the repository at this point in the history
In module mode, we want to use the `Provider` nested class. In class path mode, we do not.
  • Loading branch information
dmlloyd committed Jan 29, 2025
1 parent 1ec763d commit 0a91cb7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -302,13 +302,19 @@
<plugin>
<groupId>io.github.dmlloyd.maven</groupId>
<artifactId>module-services-plugin</artifactId>
<version>1.0</version>
<version>1.1</version>
<executions>
<execution>
<id>generate-services</id>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<excludeServices>
<!-- Modular impl is different from non-modular impl -->
<excludeService>java.util.logging.LogManager</excludeService>
</excludeServices>
</configuration>
</execution>
</executions>
</plugin>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# In class path mode, we use LogManager itself; in module mode we use LogManager.Provider instead
org.jboss.logmanager.LogManager

0 comments on commit 0a91cb7

Please sign in to comment.