[LOGMGR-322] Port handler-related fixes and improvements from jboss-logmanager-embedded
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmlloyd
commented
May 5, 2023
dmlloyd
commented
- Unify sub-handler logging and error management
- Fix encoding issue in syslog handler
…bedded` * Unify sub-handler logging and error management * Fix encoding issue in syslog handler
jamezp
reviewed
May 5, 2023
| errorManager.error(msg, ex, code); | ||
| } catch (Exception ex2) { | ||
| // use the same message as the JDK | ||
| System.err.println("Handler.reportError caught:"); |
There was a problem hiding this comment.
We should probably use the StandardOutputStreams utility here. For something like WildFly where System.out and System.err are wrapped in a logger, this could cause issues.
There was a problem hiding this comment.
This replicates the existing JDK behavior, so in WildFly I'd expect it to be caught by the enclosing process logger. In Maven (surefire) I would expect it to be captured late as well so that it doesn't cause the dreaded "streams corrupted" error that jboss-logmanager often causes. And in any event, it's an unlikely scenario. But, it's your call.
There was a problem hiding this comment.
We'll leave it for now and I'll think about how it would affect WildFly.
jamezp
approved these changes
May 8, 2023
dmlloyd
changed the title
jboss-logmanager-embeddedjboss-logmanager-embedded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.