Add new TC to Tower maps based on HGCROC and Wafer maps #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbsauvan
reviewed
Nov 20, 2018
| @@ -25,7 +25,7 @@ def custom_towers_etaphi(process, | |||
| return process | |||
|
|
|||
|
|
|||
| def custom_towers_map(process, | |||
| def custom_towers_map(process, | |||
| towermapping='L1Trigger/L1THGCal/data/tower_mapping_hgcroc_eta-phi_v0.txt', | |||
There was a problem hiding this comment.
Maybe the default parameters here would need to be updated (towermapping, minEta, maxEta)
jbsauvan
pushed a commit
that referenced
this pull request
Dec 14, 2018
Phase2 digitizer xtalk 011118
jbsauvan
pushed a commit
that referenced
this pull request
Dec 14, 2018
Use cloning in modules, Add back DeepDoubleBTagInfo.h in the meantime so PR can be tested
jbsauvan
pushed a commit
that referenced
this pull request
Jun 25, 2019
jbsauvan
pushed a commit
that referenced
this pull request
Jun 25, 2019
Improved CellGrid implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a v3 of the hgcroc mapping:
tower_mapping_hgcroc_eta-phi_v3.txtthis changes the eta phi grid to be the same as the une used for the default TC mapping and also addresses a mapping problem giving an invalid tower for 4 HGRCOs.
NOTE: this is still done using the old Cell to TC mapping and I had no information about the different sensor sizes so the distinction between 3 and 6 HGCROC modules is approximated based on the radial position of the module (as done in v0). Not sure is something has actually changed in the mapping with the new geometry.
Add a new mapping to have sums performed at wafer level:
tower_mapping_wafer_eta-phi_v3.txtSame binning as in the TC and HGCROC v3 case.
I also added the corresponing customization functions. In a future PR I will also upload the tools used to produce the mapping.