-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce padding for virtual lines #70
Conversation
|
Sorry about all the commits, for some reason I'm unable to squash them without errors. I'm not quite sure what you mean by the second part. The way I thought it was working was that the whitespace was appended onto the above and below virt lines, and then they were merged into one line. Also, yes, one whitespace of padding could be added back. |
oh I see also what kind of errors do you get when trying to squash? |
I'm trying to squash on GitHub Desktop, but it says
I think it might be because I should have squashed them before pushing to remote? |
the error messages says that there is a problem because of the merge commit after all this doesn't matter because there likely will be a squash merge or a merge commit only anyway but it just makes the pr look nicer |
For some reason I get the same error no matter the combination of commits I try to squash. If you'd like I could open another PR with a branch that has few commits. |
Ok just figured out the squash issue, should be good now. |
All the tests pass, merging. |
Hello, this PR reduces the padding of virtual lines so that lines with multiple formulas or text following formulas so they are more condensed.
Before:

After:

I'm fairly inexperienced with lua, so the code may have a better possible implementation.