Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars API must be refactored or moved to Github #972

Closed
alevohin opened this issue Jan 8, 2015 · 16 comments
Closed

Stars API must be refactored or moved to Github #972

alevohin opened this issue Jan 8, 2015 · 16 comments

Comments

@alevohin
Copy link

alevohin commented Jan 8, 2015

Stars API now is part of Repo API - it is wrong. Methods of Stars API is also have parameters of user/repo name - they are redundant. It's better to do one of this:

  1. Refactor Stars API. Methods starred, star and unstar is for logged in user only. All parameters show be removed from methods. Need new method Repo repo(). Repo must provide username and reponame for methods starred/star/unstar.
  2. Move Stars from Repo to Github.
@yegor256 yegor256 added the bug label Jan 8, 2015
@dmarkov
Copy link

dmarkov commented Jan 12, 2015

this task will get someone's attention soon

@dmarkov
Copy link

dmarkov commented Jan 12, 2015

@pinaf please pick this up, and keep in mind these instructions. Any technical questions - ask right here; This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

@pinaf
Copy link
Contributor

pinaf commented Jan 13, 2015

@dmarkov please pull from PR 981

@pinaf
Copy link
Contributor

pinaf commented Jan 13, 2015

something I believe is worth mentioning. Running mvn clean install -Pqulice on this project takes waaay too long...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:00 min
[INFO] Finished at: 2015-01-12T22:30:22-03:00
[INFO] Final Memory: 50M/410M
[INFO] ------------------------------------------------------------------------

@pinaf
Copy link
Contributor

pinaf commented Jan 14, 2015

@alevohin @dmarkov merged. please close.

@alevohin
Copy link
Author

@alevohin thanks!

@pinaf
Copy link
Contributor

pinaf commented Jan 16, 2015

@dmarkov this was closed 2 days ago. does this make my average speed slower?

@yegor256
Copy link
Member

@pinaf lower than what? :)

@pinaf
Copy link
Contributor

pinaf commented Jan 16, 2015

@yegor256 well do you measure the time to complete the task until the issue is closed or until @dmarkov notices that the issue is closed?

@yegor256
Copy link
Member

@pinaf it's the time between the moment you are assigned to the task and the moment you're paid

@dmarkov
Copy link

dmarkov commented Jan 19, 2015

@pinaf Much obliged! I've added 30 mins to your account in payment "AP-5T852175BW507970C". +30 added to your rating, at the moment it is: +60

@yegor256
Copy link
Member

@dmarkov please add extra 15 mins to @alevohin

@dmarkov
Copy link

dmarkov commented Jan 23, 2015

@dmarkov please add extra 15 mins to @alevohin

@yegor256 I've paid 15 mins to @alevohin in transaction 50614484

@yegor256
Copy link
Member

@rultor release, tag is 0.18.9

@rultor
Copy link
Contributor

rultor commented Jan 27, 2015

@rultor release, tag is 0.18.9

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 27, 2015

@rultor release, tag is 0.18.9

@yegor256 Done! FYI, the full log is here (took me 20min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants