Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#972: Stars no longer depends on user/repo parameters. It now has its ow... #981

Merged
merged 2 commits into from
Jan 14, 2015
Merged

#972: Stars no longer depends on user/repo parameters. It now has its ow... #981

merged 2 commits into from
Jan 14, 2015

Conversation

pinaf
Copy link
Contributor

@pinaf pinaf commented Jan 13, 2015

@pinaf pinaf mentioned this pull request Jan 13, 2015
Closed
@dmarkov
Copy link

dmarkov commented Jan 14, 2015

Thanks for your pull request, let me find someone who can review it

@dmarkov
Copy link

dmarkov commented Jan 14, 2015

@carlosmiranda could you please review this pull request

carlosmiranda
carlosmiranda reviewed Jan 14, 2015
View reviewed changes
src/test/java/com/jcabi/github/RtStarsTest.java
@@ -60,14 +61,19 @@ public void checkIfRepoStarred() throws Exception {
new MkAnswer.Simple(HttpURLConnection.HTTP_NO_CONTENT)
).next(new MkAnswer.Simple(HttpURLConnection.HTTP_NOT_FOUND))
.start();
final Stars stars = new RtStars(
new ApacheRequest(container.home())
final Stars truestars = new RtStars(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this variable stars or starred. Better avoid compound variable names: http://www.yegor256.com/2014/04/27/typical-mistakes-in-java-code.html#variable-names

@carlosmiranda
Copy link
Contributor

@pinaf A couple of minor comments above.

@pinaf
Copy link
Contributor Author

pinaf commented Jan 14, 2015

@carlosmiranda there you go.

@carlosmiranda
Copy link
Contributor

@pinaf Thanks, looks good now.

@carlosmiranda
Copy link
Contributor

@rultor merge please

@rultor
Copy link
Contributor

rultor commented Jan 14, 2015

@rultor merge please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Member

@rultor merge pls

@rultor
Copy link
Contributor

rultor commented Jan 14, 2015

@rultor merge pls

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit eaf5425 into jcabi:master Jan 14, 2015
@rultor
Copy link
Contributor

rultor commented Jan 14, 2015

@rultor merge pls

@yegor256 Done! FYI, the full log is here (took me 11min)

@dmarkov
Copy link

dmarkov commented Jan 19, 2015

@carlosmiranda 16 mins sent to your balance (ID 50342821), many thanks!

+16 added to your rating, current score is: +1304

@dmarkov
Copy link

dmarkov commented Jan 19, 2015

@rultor please deploy

@rultor
Copy link
Contributor

rultor commented Jan 19, 2015

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 19, 2015

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 10min)

@pinaf pinaf deleted the 972 branch February 3, 2015 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@carlosmiranda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pinaf @dmarkov @carlosmiranda @rultor @yegor256