Issue #952 - implementing iterate() and get() methods in MkNotifications #1174

prondzyn · 2015-09-30T21:18:00Z

Related to issue #952. iterate() is based on empty list and get() method on simple MkNotification object.

prondzyn · 2015-10-01T03:51:25Z

@dmarkov please check the Travis build because the error does not look to be connected with my changes

dmarkov · 2015-10-01T07:52:57Z

@prondzyn Thanks, I will find someone to review this PR soon

dmarkov · 2015-10-01T07:57:56Z

@dmzaytsev it's yours, please review

dmzaytsev · 2015-10-01T08:18:23Z

src/main/java/com/jcabi/github/mock/MkNotifications.java

    @Override
    public Iterable<Notification> iterate() {
-        throw new NotImplementedException("MkNotifications#iterate");
+        return Collections.emptyList();


@prondzyn I think you should return a real collection instead empty one.
Let's create the collection inside the constructor, size of the collection can be a parameter.

@prondzyn you can fill the collection in constructor as well

dmzaytsev · 2015-10-01T08:27:53Z

@prondzyn please see 7 comments/questions above

…tion in MkNotifications

prondzyn · 2015-10-02T05:49:19Z

@dmzaytsev please check my improvements

dmzaytsev · 2015-10-02T06:58:22Z

src/main/java/com/jcabi/github/mock/MkNotifications.java

+        this.notifications = Collections
+            .<Notification>nCopies(
+                quantity,
+                new MkNotification(identifier += 1)


@prondzyn I think you get quantity copies of new MkNotification(1), right?
Let's initialize this one via for loop.

@dmzaytsev sorry, my mistake.

But when I use for I need to add @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops"). Is it not a problem?

@prondzyn sure, you can suppress this warning

dmzaytsev · 2015-10-02T07:08:55Z

@prondzyn please see one comment above

prondzyn · 2015-10-02T07:46:40Z

@dmzaytsev please check my fix now

dmzaytsev · 2015-10-02T07:57:38Z

src/main/java/com/jcabi/github/mock/MkNotifications.java

+    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
+    MkNotifications(final int quantity) {
+        this.notifications = new ArrayList<Notification>(quantity);
+        for (int index = 0; index < quantity; index += 1) {


@prondzyn ++ index

dmzaytsev · 2015-10-02T07:59:34Z

@prondzyn looks good just one minor remark

prondzyn · 2015-10-02T08:21:53Z

@dmzaytsev updated as you requested. Thanks for all your remarks. I still need to get familiar with your coding style.

dmzaytsev · 2015-10-02T08:31:11Z

@prondzyn thanks

dmzaytsev · 2015-10-02T08:31:21Z

@rultor merge

rultor · 2015-10-02T08:32:14Z

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-10-02T15:37:28Z

@rultor try to merge

…bi#1178

prondzyn · 2015-10-06T07:29:02Z

@dmzaytsev I ignored one test from RtIssueITCase and updated description of #1178

dmzaytsev · 2015-10-06T09:53:55Z

@rultor merge

rultor · 2015-10-06T09:54:26Z

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-10-06T20:36:34Z

@prondzyn if you ignore any test, don't forget to add some description there, explaining why the test is ignored. Everybody should be able to understand why @Ignore is there, in a year, for example.

prondzyn · 2015-10-07T05:31:18Z

@yegor256 Understood. Comment added.

yegor256 · 2015-10-07T22:49:25Z

@rultor try to merge

rultor · 2015-10-07T22:50:04Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-10-07T23:01:10Z

@rultor try to merge

@prondzyn @yegor256 Oops, I failed. You can see the full log here (spent 11min)

INFO: "reading src/main/java/com/jcabi/github/Branches.java..."
INFO: "reading src/main/java/com/jcabi/github/Bulk.java..."
INFO: "reading src/main/java/com/jcabi/github/Collaborators.java..."
INFO: "reading src/main/java/com/jcabi/github/Comment.java..."
INFO: "reading src/main/java/com/jcabi/github/Comments.java..."
INFO: "reading src/main/java/com/jcabi/github/Commit.java..."
INFO: "reading src/main/java/com/jcabi/github/Commits.java..."
INFO: "reading src/main/java/com/jcabi/github/CommitsComparison.java..."
INFO: "reading src/main/java/com/jcabi/github/Content.java..."
INFO: "reading src/main/java/com/jcabi/github/Contents.java..."
INFO: "reading src/main/java/com/jcabi/github/Coordinates.java..."
INFO: "reading src/main/java/com/jcabi/github/DeployKey.java..."
INFO: "reading src/main/java/com/jcabi/github/DeployKeys.java..."
INFO: "reading src/main/java/com/jcabi/github/Event.java..."
INFO: "reading src/main/java/com/jcabi/github/FileChange.java..."
INFO: "reading src/main/java/com/jcabi/github/Fork.java..."
INFO: "reading src/main/java/com/jcabi/github/Forks.java..."
INFO: "reading src/main/java/com/jcabi/github/Gist.java..."
INFO: "reading src/main/java/com/jcabi/github/GistComment.java..."
INFO: "reading src/main/java/com/jcabi/github/GistComments.java..."
INFO: "reading src/main/java/com/jcabi/github/Gists.java..."
INFO: "reading src/main/java/com/jcabi/github/Git.java..."
INFO: "reading src/main/java/com/jcabi/github/GitHubThread.java..."
INFO: "reading src/main/java/com/jcabi/github/Github.java..."
INFO: "reading src/main/java/com/jcabi/github/Gitignores.java..."
INFO: "reading src/main/java/com/jcabi/github/Hook.java..."
INFO: "reading src/main/java/com/jcabi/github/Hooks.java..."
INFO: "puzzle 1106-3aa88d70 30/IMP at src/main/java/com/jcabi/github/Hooks.java"
INFO: "reading src/main/java/com/jcabi/github/Issue.java..."
INFO: "reading src/main/java/com/jcabi/github/IssueEvents.java..."
INFO: "reading src/main/java/com/jcabi/github/IssueLabels.java..."
INFO: "reading src/main/java/com/jcabi/github/Issues.java..."
INFO: "reading src/main/java/com/jcabi/github/JsonPatchable.java..."
INFO: "reading src/main/java/com/jcabi/github/JsonReadable.java..."
INFO: "reading src/main/java/com/jcabi/github/Label.java..."
INFO: "reading src/main/java/com/jcabi/github/Labels.java..."
INFO: "reading src/main/java/com/jcabi/github/Language.java..."
INFO: "reading src/main/java/com/jcabi/github/Limit.java..."
INFO: "reading src/main/java/com/jcabi/github/Limits.java..."
/var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/r/repo/src/main/java/com/jcabi/github/Notification.java", #<PDD::Error: Suspicious TODO in line #41>] (PDD::Error)
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd/source.rb:142:in `puzzles'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:97:in `block (3 levels) in xml'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:96:in `each'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:96:in `block (2 levels) in xml'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:391:in `call'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:391:in `insert'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:375:in `method_missing'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:95:in `block in xml'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:293:in `initialize'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:93:in `new'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:93:in `xml'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/bin/pdd:90:in `<top (required)>'
    from /usr/local/bin/pdd:23:in `load'
    from /usr/local/bin/pdd:23:in `<main>'
INFO: "reading src/main/java/com/jcabi/github/Markdown.java..."
INFO: "reading src/main/java/com/jcabi/github/MergeState.java..."
INFO: "reading src/main/java/com/jcabi/github/Milestone.java..."
INFO: "reading src/main/java/com/jcabi/github/Milestones.java..."
INFO: "reading src/main/java/com/jcabi/github/Notification.java..."

prondzyn · 2015-10-09T05:47:14Z

@yegor256 what should I do now? It is not in part which I did not touch.

yegor256 · 2015-10-09T17:38:42Z

@prondzyn just fix it and move on. It should be very easy to fix, see https://github.com/teamed/pdd

prondzyn · 2015-10-09T19:09:42Z

@yegor256 should work now

prondzyn · 2015-10-09T19:17:18Z

@rultor merge

rultor · 2015-10-09T19:17:44Z

@rultor merge

@prondzyn Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-10-09T21:42:22Z

@rultor try to merge

rultor · 2015-10-09T21:43:43Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-10-09T21:52:29Z

@rultor try to merge

@prondzyn @yegor256 Oops, I failed. You can see the full log here (spent 9min)

INFO: "reading src/test/java/com/jcabi/github/RtContentTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtContentsITCase.java..."
INFO: "puzzle 863-4e783bd3 0/IMP at src/test/java/com/jcabi/github/RtContentsITCase.java"
INFO: "reading src/test/java/com/jcabi/github/RtContentsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtDeployKeyTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtDeployKeysITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtDeployKeysTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtEventTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtForkTest.java..."
INFO: "puzzle 989-33d6f233 0/IMP at src/test/java/com/jcabi/github/RtForkTest.java"
INFO: "reading src/test/java/com/jcabi/github/RtForksITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtForksTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistCommentITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistCommentTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistCommentsITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistCommentsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistsITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGistsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGitTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGithubITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGithubTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGitignoresITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtGitignoresTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtHookTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtHooksITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtHooksTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtIssueITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtIssueLabelsITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtIssueTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtIssuesITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtIssuesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtJsonTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtLabelTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtLabelsITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtLabelsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtLimitTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtLimitsITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtMarkdownITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtMarkdownTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtMilestonesITCase.java..."
INFO: "reading src/test/java/com/jcabi/github/RtMilestonesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/RtNotificationsITestCase.java..."
/var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/r/repo/src/test/java/com/jcabi/github/RtNotificationsITestCase.java", #<PDD::Error: Suspicious TODO in line #36>] (PDD::Error)
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd/source.rb:142:in `puzzles'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:97:in `block (3 levels) in xml'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:96:in `each'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:96:in `block (2 levels) in xml'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:391:in `call'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:391:in `insert'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:375:in `method_missing'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:95:in `block in xml'
    from /var/lib/gems/1.9.1/gems/nokogiri-1.6.5/lib/nokogiri/xml/builder.rb:293:in `initialize'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:93:in `new'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/lib/pdd.rb:93:in `xml'
    from /var/lib/gems/1.9.1/gems/pdd-0.15/bin/pdd:90:in `<top (required)>'
    from /usr/local/bin/pdd:23:in `load'
    from /usr/local/bin/pdd:23:in `<main>'

prondzyn · 2015-10-10T04:45:19Z

@rultor merge

rultor · 2015-10-10T04:46:23Z

@rultor merge

@prondzyn Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-10-12T19:54:06Z

@rultor try to merge

rultor · 2015-10-12T19:54:24Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-10-12T19:59:05Z

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 5min)

dmarkov · 2015-10-15T07:36:15Z

@dmzaytsev Thanks a lot, I just topped your account for 26 mins, transaction ID 67397152, total time was 288 hours and 46 mins. extra minutes for review comments (c=11). +26 to your rating, your total score is +1343

dmarkov · 2015-10-15T07:37:01Z

@rultor please deploy

rultor · 2015-10-15T07:38:00Z

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor · 2015-10-15T07:47:13Z

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 9min)

Issue jcabi#952 - iterate and get methods implemented in MkNotifications

cb7a58d

prondzyn mentioned this pull request Sep 30, 2015

MkNotifications.java:45-46: Implement iterate() and get() operations... #952

Closed

dmarkov added CR @dmzaytsev labels Oct 1, 2015

dmarkov assigned dmzaytsev Oct 1, 2015

dmarkov added the 15 mins label Oct 1, 2015

dmzaytsev reviewed Oct 1, 2015
View reviewed changes

Issue jcabi#952 - improvements for iterate and get methods implementa…

b318031

…tion in MkNotifications

dmzaytsev reviewed Oct 2, 2015
View reviewed changes

Issue jcabi#952 - improvements for MkNotifications initialization

c8c6e26

dmzaytsev reviewed Oct 2, 2015
View reviewed changes

Issue jcabi#952 - small improvement after code review

29dd973

Ignoring RtIssueITCase.talksInGithubProject test because of issue jca…

da07bb5

…bi#1178

adding comment why RtIssueITCase.talksInGithubProject test is ignored

f72fdd7

TODO format fix

cbb5b53

TODO format fix

a3d3682

rultor merged commit a3d3682 into jcabi:master Oct 12, 2015

Issue #952 - implementing iterate() and get() methods in MkNotifications #1174

Issue #952 - implementing iterate() and get() methods in MkNotifications #1174

Conversation

prondzyn commented Sep 30, 2015

prondzyn commented Oct 1, 2015

dmarkov commented Oct 1, 2015

dmarkov commented Oct 1, 2015

dmzaytsev Oct 1, 2015

Choose a reason for hiding this comment

dmzaytsev Oct 1, 2015

Choose a reason for hiding this comment

dmzaytsev commented Oct 1, 2015

prondzyn commented Oct 2, 2015

dmzaytsev Oct 2, 2015

Choose a reason for hiding this comment

prondzyn Oct 2, 2015

Choose a reason for hiding this comment

dmzaytsev Oct 2, 2015

Choose a reason for hiding this comment

dmzaytsev commented Oct 2, 2015

prondzyn commented Oct 2, 2015

dmzaytsev Oct 2, 2015

Choose a reason for hiding this comment

dmzaytsev commented Oct 2, 2015

prondzyn commented Oct 2, 2015

dmzaytsev commented Oct 2, 2015

dmzaytsev commented Oct 2, 2015

rultor commented Oct 2, 2015

yegor256 commented Oct 2, 2015

prondzyn commented Oct 6, 2015

dmzaytsev commented Oct 6, 2015

rultor commented Oct 6, 2015

yegor256 commented Oct 6, 2015

prondzyn commented Oct 7, 2015

yegor256 commented Oct 7, 2015

rultor commented Oct 7, 2015

rultor commented Oct 7, 2015

prondzyn commented Oct 9, 2015

yegor256 commented Oct 9, 2015

prondzyn commented Oct 9, 2015

prondzyn commented Oct 9, 2015

rultor commented Oct 9, 2015

yegor256 commented Oct 9, 2015

rultor commented Oct 9, 2015

rultor commented Oct 9, 2015

prondzyn commented Oct 10, 2015

rultor commented Oct 10, 2015

yegor256 commented Oct 12, 2015

rultor commented Oct 12, 2015

rultor commented Oct 12, 2015

dmarkov commented Oct 15, 2015

dmarkov commented Oct 15, 2015

rultor commented Oct 15, 2015

rultor commented Oct 15, 2015