MkRepo.java:68-69: Implement languages() method. Don't forget... #953 #994
Conversation
|
Many thanks for the PR, let me find a reviewer for it |
|
@longtimeago please review this one |
| @@ -281,7 +279,7 @@ public Notifications notifications() { | |||
|
|
|||
| @Override | |||
| public Iterable<Language> languages() { | |||
| throw new NotImplementedException("MkRepo#languages"); | |||
| return new ArrayList<Language>(0); | |||
There was a problem hiding this comment.
it would be nice to have several languages inside. Empty list is useless
…fter code review.
|
@longtimeago updated, please review. |
| user, | ||
| new Coordinates.Simple(user, "testrepo4") | ||
| ); | ||
| MatcherAssert.assertThat(repo.languages(), Matchers.notNullValue()); |
There was a problem hiding this comment.
please, also check at least elements count
|
@nhekfqn One more remark |
…fter code review 2.
|
@longtimeago updated, please review. |
| final int size = 3; | ||
| MatcherAssert.assertThat( | ||
| Lists.newArrayList(languages), | ||
| Matchers.hasSize(size) |
There was a problem hiding this comment.
instead of one-time variable size please use Tv.THREE
…fter code review 3.
|
@longtimeago updated, please review. |
|
@nhekfqn Thank you! |
|
@rultor good to merge |
@longtimeago Thanks for your request. @yegor256 Please confirm this. |
|
@rultor merge this |
|
@rultor try to merge again |
|
@longtimeago thank you, added 15 mins to your acc, payment num is |
|
@rultor deploy now pls |
|
Changes Unknown when pulling b164d64 on nhekfqn:976 into * on jcabi:master*. |
No description provided.