#16 - code style violations in headers

[maurezen]

Added license.txt to configuration. Please also note jcabi/jcabi-parent#19

[dmarkov]

Many thanks for the PR, let me find a reviewer for it

[maurezen]

@dmarkov any progress with that?

[maurezen]

@dmarkov @yegor256 please find someone to review this PR. It's been quite a while.

[dmarkov]

@carlosmiranda please review this one

[carlosmiranda]

Let's align this line with line 102 above.

[carlosmiranda]

@maurezen One minor comment.

[maurezen]

@carlosmiranda fixed.

[carlosmiranda]

@rultor can we merge?

[rultor]

@rultor can we merge?

@carlosmiranda Your .rultor.yml file has a problem:

ScannerException: while scanning a double-quoted scalar
 in 'string', line 30, column 7:
        - "sed 's/<snapshotVersion>.*<\/sn ... 
          ^
found unknown escape character /(47)
 in 'string', line 30, column 36:
        - "sed 's/<snapshotVersion>.*<\/snapshotVersion>/<snapshotVersi ... 
                                       ^

This page explains how to configure it properly. The YAML format is explained here.

[yegor256]

@rultor I fixed config, try to merge again

[rultor]

@rultor I fixed config, try to merge again

@yegor256 This is how I understand the .rultor.yml file in the root directory of this repository:

<?xml version="1.0" encoding="UTF-8"?>
<p>
   <entry key="assets">
      <entry key="settings.xml">yegor256/home#assets/jcabi/settings.xml</entry>
      <entry key="pubring.gpg">yegor256/home#assets/pubring.gpg</entry>
      <entry key="secring.gpg">yegor256/home#assets/secring.gpg</entry>
      <entry key="s3cfg">yegor256/home#assets/s3cfg</entry>
   </entry>
   <entry key="env">
      <entry key="MAVEN_OPTS">-XX:MaxPermSize=256m -Xmx1g</entry>
   </entry>
   <entry key="install">
      <item>sudo gem install pdd</item>
   </entry>
   <entry key="architect">
      <item>yegor256</item>
      <item>dmarkov</item>
   </entry>
   <entry key="merge">
      <entry key="script">mvn clean install -Pqulice --errors --settings ../settings.xml
mvn clean
pdd --source=$(pwd) --verbose --file=/dev/null
</entry>
   </entry>
   <entry key="deploy">
      <entry key="script">mvn clean deploy -Pqulice --errors --settings ../settings.xml
mvn clean
pdd --source=$(pwd) --verbose --file=jcabi-manifests.xml
s3cmd --no-progress put jcabi-manifests.xml --config=../s3cfg s3://pdd.teamed.io/jcabi-manifests.xml
</entry>
   </entry>
   <entry key="release">
      <entry key="script">if [ -n ${snapshot} ]; then
  echo 'Please specify next snapshot version, e.g. @rultor release, tag=`2.0`, snapshot=`2.1-SNAPSHOT`'
  exit 1
fi
mvn versions:set "-DnewVersion=${tag}"
sed -i "s|&lt;snapshotVersion&gt;.*&lt;/snapshotVersion&gt;|&lt;snapshotVersion&gt;${nextSnapshotVersion}&lt;/snapshotVersion&gt;|" pom.xml
git commit -am "${tag}"
mvn clean deploy -Pqulice -Psonatype -Pjcabi --errors --settings ../settings.xml
mvn clean site-deploy -Psite --errors --settings ../settings.xml</entry>
   </entry>
</p>

This page explains how to configure it.

[yegor256]

@rultor merge it! :)

[rultor]

@rultor merge it! :)

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it! :)

@yegor256 Oops, I failed. You can see the full log here (spent 3min)

[carlosmiranda]

Let's add a single space here (f in line 104 should be aligned with t, not @).

[carlosmiranda]

@maurezen rultor is complaining about puzzle format. Let's fix it (see my latest code comment above)

[maurezen]

@carlosmiranda done.

[carlosmiranda]

@rultor Try the merge again please

[rultor]

@rultor Try the merge again please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@rultor merge it

[rultor]

@rultor merge it

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it

@yegor256 Done! FYI, the full log is here (took me 4min)

[dmarkov]

@carlosmiranda done, I added 20 mins in payment 50570821

added +20 to your rating, now it is equal to +1750

[dmarkov]

@rultor deploy pls

[rultor]

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 5min)