Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make com.jcabi.matchers.XPathMatcher public #39

Closed
ilyakharlamov opened this issue Feb 14, 2019 · 5 comments
Closed

Make com.jcabi.matchers.XPathMatcher public #39

ilyakharlamov opened this issue Feb 14, 2019 · 5 comments

Comments

@ilyakharlamov
Copy link

If someone wants to match XPath with jcabi-matchers the only way to do that is is via
static XhtmlMatchers.hasXPath()
however, it's static, not OO, not EO.
The jcabi already has a good OO/EO matcher com.jcabi.matchers.XPathMatcher, however, it's package-private and cannot be used by any project.

This issue is regarding making com.jcabi.matchers.XPathMatcher public.

@0crat
Copy link

0crat commented Feb 14, 2019

@yegor256/z please, pay attention to this issue

@0crat
Copy link

0crat commented Feb 14, 2019

@ilyakharlamov/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@yegor256
Copy link
Member

@ilyakharlamov you are welcome to make a pull request

yegor256 added a commit that referenced this issue Aug 24, 2022
@yegor256
Copy link
Member

@ilyakharlamov I made it public in 1.6.0 see 0bea49c

@0crat
Copy link

0crat commented Aug 24, 2022

Job gh:jcabi/jcabi-matchers#39 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants