Add 'socket' param to override mysql socket location #51

seanf · 2014-12-03T06:40:03Z

See #10 and #50

Note: I haven't been able to run mvn clean install -Pqulice because the tests don't work on my machine (Fedora 20).

yegor256 · 2014-12-03T06:52:46Z

what fails on Fedora? can you report a bug about it? in the mean time, please run mvn clean install -Pqulice -DskipTests and fix a few static analysis violations.

seanf · 2014-12-03T07:28:10Z

I'll try to collect something meaningful for a bug report about the tests. It seems to download a lot of Maven artifacts from Maven Central every single time, so it's taking a while.

I ran mvn clean install -Pqulice -DskipTests -Dinvoker.skip (it's somewhat unintuitive that skipTests doesn't work on the invoker plugin), but I got this even without my changes:

[ERROR] Internal error: java.lang.NullPointerException -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.NullPointerException
        at org.apache.maven.lifecycle.internal.BuilderCommon.handleBuildError(BuilderCommon.java:128)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:95)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.NullPointerException
        at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromChildren(CollectionConverter.java:157)
        at org.codehaus.plexus.component.configurator.converters.composite.CollectionConverter.fromConfiguration(CollectionConverter.java:112)
        at org.codehaus.plexus.component.configurator.converters.ComponentValueSetter.configure(ComponentValueSetter.java:289)
        at org.codehaus.plexus.component.configurator.converters.composite.ObjectWithFieldsConverter.processConfiguration(ObjectWithFieldsConverter.java:161)
        at org.codehaus.plexus.component.configurator.BasicComponentConfigurator.configureComponent(BasicComponentConfigurator.java:56)
        at org.apache.maven.plugin.internal.DefaultMavenPluginManager.populatePluginFields(DefaultMavenPluginManager.java:567)
        at org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo(DefaultMavenPluginManager.java:529)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:92)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        ... 16 more

All of that happens on master, even before I check out this branch with my changes.

yegor256 · 2014-12-03T07:43:10Z

Looks like you're using an old version of Maven. Try 3.2+

seanf · 2014-12-03T07:50:25Z

Oh right. I'll try that.

Mind if I add this to pom.xml?

                            <requireMavenVersion>
                              <version>3.2.3</version>
                            </requireMavenVersion>

On 3 December 2014 at 17:43, Yegor Bugayenko [email protected]
wrote:

Looks like you're using an old version of Maven. Try 3.2+

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

seanf · 2014-12-03T08:02:49Z

I've just realised I had the wrong branch, but master branch has these
errors:

[ERROR] JSR-303 validator failed to initialize: Unable to instantiate

Configuration. (see http://www.jcabi.com/jcabi-aspects/jsr-303.html)

[ERROR]

/src/it/parallel/src/test/java/com/jcabi/ParallelITCase.java[53]: Private
constant "SECOND" is not used (ConstantUsageCheck)

On 3 December 2014 at 16:52, Yegor Bugayenko [email protected]
wrote:

what fails on Fedora? can you report a bug about it? in the mean time,
please run mvn clean install -Pqulice -DskipTests and fix a few static
analysis violations.

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

seanf · 2014-12-03T08:09:30Z

[ERROR] /src/main/java/com/jcabi/mysql/maven/plugin/Instances.java[178]: Name 'socketFile' must match pattern '^[a-z]{3,}$'. (ParameterNameCheck)

Does this mean you only want one word socket, or would you prefer socketfile in lower case?

yegor256 · 2014-12-03T08:10:50Z

Yes, add that <requireMavenVersion> to the pom please.

I'll check the master branch now... Should be clean.

socket would be the best choice.

seanf · 2014-12-03T08:13:51Z

Actually socket is already taken as a local variable. How about sock? (Sticking to one word is quite constraining.)

seanf · 2014-12-03T08:14:14Z

By the way, would you prefer I amended the original commit, or added a commit with the changes?

yegor256 · 2014-12-03T08:15:16Z

let's call it socketfile than. just add commits to your branch, Github will pick up your changes

yegor256 · 2014-12-03T08:22:27Z

@seanf I fixed master in efe420a thanks for reporting!

seanf · 2014-12-03T08:31:32Z

Thanks. Would you prefer I merge master in, or rebase?
On 03/12/2014 6:26 pm, "Yegor Bugayenko" [email protected] wrote:

@seanf https://github.com/seanf I fixed master in efe420a
efe420a
thanks for reporting!

—
Reply to this email directly or view it on GitHub
#51 (comment)
.

yegor256 · 2014-12-03T08:31:58Z

Just merge it in, with git pull upstream master

seanf · 2014-12-04T01:28:26Z

This is now passing mvn clean install -Pqulice on my machine (as long as I run it from a shallow directory like /jm.

@yegor256 Assuming you merge it, how soon is the next release likely to be?

yegor256 · 2014-12-04T05:26:22Z

@rultor merge

rultor · 2014-12-04T05:26:34Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T05:32:11Z

@rultor merge

@yegor256 Oops, I failed. You can see the full log here (spent 5min)

seanf · 2014-12-04T05:43:16Z

@yegor256 Do you want me to downgrade the required Maven to 3.2.2, or will you upgrade Maven on rultor?

yegor256 · 2014-12-04T06:23:16Z

let's change pom.xml file, it'll be easier and we don't need 3.2.3. any 3.2.x is enough

seanf · 2014-12-04T06:24:28Z

I should have used maven.version anyway (it's 3.2.1).

yegor256 · 2014-12-04T06:30:00Z

@rultor merge again

rultor · 2014-12-04T06:30:38Z

@rultor merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T06:43:39Z

@rultor merge again

@yegor256 Oops, I failed. You can see the full log here (spent 13min)

yegor256 · 2014-12-04T06:45:25Z

@rultor try to merge again

rultor · 2014-12-04T06:45:49Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T06:58:51Z

@rultor try to merge again

@yegor256 Oops, I failed. You can see the full log here (spent 13min)

seanf · 2014-12-04T07:01:27Z

@yegor256 It's saying "No space left on device" - have you got any control over that?

yegor256 · 2014-12-04T07:18:03Z

@seanf that's really weird... I'm investigating now...

yegor256 · 2014-12-04T07:19:05Z

@rultor try to merge again

rultor · 2014-12-04T07:19:07Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T07:30:04Z

@rultor try to merge again

@yegor256 Oops, I failed. You can see the full log here (spent 11min)

yegor256 · 2014-12-04T07:31:07Z

hm.. it's a mystery. the server has enough space... I'll try to do something now

yegor256 · 2014-12-04T07:46:45Z

it's an issue with docker, it gives us only 10Gb disc quota by default. I'm working on it now: yegor256/rultor#669

yegor256 · 2014-12-04T08:10:03Z

@rultor merge again

rultor · 2014-12-04T08:10:32Z

@rultor merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T08:21:31Z

@rultor merge again

@yegor256 Oops, I failed. You can see the full log here (spent 11min)

yegor256 · 2014-12-04T08:36:12Z

@rultor try to merge again

rultor · 2014-12-04T08:36:41Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2014-12-04T08:46:38Z

@rultor try to merge again

@yegor256 Done! FYI, the full log is here (took me 10min)

Add 'socket' param to override mysql socket location

29e6546

seanf mentioned this pull request Dec 3, 2014

Socket file path is too long #50

Open

Fix checkstyle violations

7696f29

yegor256 pushed a commit that referenced this pull request Dec 3, 2014

#51 build is clean

efe420a

seanf added 3 commits December 3, 2014 19:40

Merge remote-tracking branch 'origin/master' into override-socket

1c606ba

Enforce Maven version >= 3.2.3

ffd0fca

Make PMD happy

e2f4c16

seanf mentioned this pull request Dec 4, 2014

Build fails with "socket file path is too long" when run from deep directory #52

Closed

Use maven.version (3.2.1) for the enforcer rule, not 3.2.3

2c0a197

yegor256 pushed a commit that referenced this pull request Dec 4, 2014

#51 delete target directories after each integration test

b6dd01b

yegor256 pushed a commit that referenced this pull request Dec 4, 2014

#51 fix in rultor config

9381060

rultor merged commit 2c0a197 into jcabi:master Dec 4, 2014

seanf deleted the override-socket branch December 4, 2014 08:47

Add 'socket' param to override mysql socket location #51

Add 'socket' param to override mysql socket location #51

Conversation

seanf commented Dec 3, 2014

yegor256 commented Dec 3, 2014

seanf commented Dec 3, 2014

yegor256 commented Dec 3, 2014

seanf commented Dec 3, 2014

seanf commented Dec 3, 2014

seanf commented Dec 3, 2014

yegor256 commented Dec 3, 2014

seanf commented Dec 3, 2014

seanf commented Dec 3, 2014

yegor256 commented Dec 3, 2014

yegor256 commented Dec 3, 2014

seanf commented Dec 3, 2014

yegor256 commented Dec 3, 2014

seanf commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014

seanf commented Dec 4, 2014

yegor256 commented Dec 4, 2014

seanf commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014

seanf commented Dec 4, 2014

yegor256 commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014

yegor256 commented Dec 4, 2014

yegor256 commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014

yegor256 commented Dec 4, 2014

rultor commented Dec 4, 2014

rultor commented Dec 4, 2014