Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #4

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Master #4

wants to merge 17 commits into from

Conversation

aviram120
Copy link

Aviram Mizrachi

@robi-y
Copy link
Contributor

robi-y commented May 17, 2015

Hi,
This is not the TDD process, also for submitting in pairs you need to ping-pong with the commits

@aviram120
Copy link
Author

what do you mean?
first write the test, commit, wirte the function(check the test), commit ect.?

@robi-y
Copy link
Contributor

robi-y commented May 18, 2015

Yes. In case you want to submit in pair each stage is committed alternately
by the pair

On Sun, May 17, 2015 at 9:02 PM, aviram mizrachi [email protected]
wrote:

what do you mean?
first write the test, commit, wirte the function(check the test), commit
ect.?


Reply to this email directly or view it on GitHub
#4 (comment)
.

@aviram120
Copy link
Author

Repairs for tdd HW

@robi-y
Copy link
Contributor

robi-y commented May 22, 2015

This is much much better! what is the other PR #22 you opened?
Commit messages are not so clear. No REFACTORING stage
I left some what more meaningful comment on one of the commit 6282b57
Still missing feature 3 of the mission...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants