Add drain-before-shutdown behavior (fixes #24) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| notification = queue.poll(); | ||
| } | ||
|
|
||
| if (notification != null) { | ||
| connection.sendNotification(notification); | ||
| } else { | ||
| if (drainingBeforeShutdown) { |
There was a problem hiding this comment.
So you can't drain before you send all of your notifications?
…into drain_retry_queue_before_shutdown Conflicts: src/main/java/com/relayrides/pushy/apns/PushManager.java
…hread on shutdown so it notices that it should be draining the retry queue.
|
👍 |
|
@romanzadov Cool -- thanks for the read. Tests are failing, though, so we'll need to get that figured out before moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
PushManager's shutdown behavior to drain the internal retry queue before gracefully closing connections.