Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry related changes #1

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

aucampia
Copy link

@aucampia aucampia commented Jan 3, 2023

  • .github/workflows/validate.yaml:
    • Cache the default XDG_CACHE_HOME instead of messing with PIP_CACHE_DIR and the variable. This simplifies caching quite a bit and also ensures caching works for poetry.
    • Install poetry for extra-tasks, so that poetry install works correctly.
    • Get an auth token in extra-tasks so we don't get hit by rate limiting.
  • docs/conf.py:
    • Disable nit picking on pre-python 3.8 as this causes problems with older sphinx.
  • docs/developers.rst and docs/docs.rst:
    • Incorporate poetry into instructions.
  • docker-compose.yml:
    • Set POETRY_VIRTUALENVS_IN_PROJECT=1 so that the .venv goes into a docker volume instead of going to emphemeral storage.
  • Dockerfile.devcontainer
    • Don't install dependencies globally. With poetry, everyone should use poetry, and when using poetry the global python environment should not be used, so if people use the devcontainer correctly the global dependencies should have no effect.
  • poetry.lock
    • Ran poetry lock after changes to pyproject.toml, most notable change is the stuff added to the dev Poetry dependency group is no longer optional.
  • pyproject.toml:
    • Simplified the dependency constrains for networkx as this was causing problems with tox, as tox was running pip install with 'networkx<3.0.0,>=2.6.2; (python_version >= "3.7" and python_version < "3.8") and extra == "networkx"' 'networkx<3.0.0,>=2.8.8; (python_version >= "3.8" and python_version < "4.0") and extra == "networkx"' and the extra == "networkx" here would never be true.
    • Added a dev poetry dependendcy group with everything that is needed for a sane development environment so that poetry install gets you a sane dev environment.
  • Taskfile.yml:
    • Changed the commands so that everything works as before but now instead runs things with poetry.
    • Removed the legacy venv handling and replaced it with poetry equivalents.
  • tox.ini:
    • Don't set nitpicky (-n) on the command line as it is being set conditionally on python version in docs/conf.py now.

- `.github/workflows/validate.yaml`:
  - Cache the default `XDG_CACHE_HOME` instead of messing with
    `PIP_CACHE_DIR` and the variable. This simplifies caching quite a bit
    and also ensures caching works for poetry.
  - Install poetry for `extra-tasks`, so that poetry install works correctly.
  - Get an auth token in `extra-tasks` so we don't get hit by rate limiting.
- `docs/conf.py`:
  - Disable nit picking on pre-python 3.7 as this causes problems with older sphinx.
- `docs/developers.rst` and `docs/docs.rst`:
  - Incorporate poetry into instructions.
- `docker-compose.yml`:
  - Set `POETRY_VIRTUALENVS_IN_PROJECT=1` so that the `.venv` goes into a docker
    volume instead of going to emphemeral storage.
- `Dockerfile.devcontainer`
  - Don't install dependencies globally. With poetry, everyone should use
    poetry, and when using poetry the global python environment should not be
    used, so if people use the devcontainer correctly the global dependencies
    should have no effect.
- `poetry.lock`
  - Ran `poetry lock` after changes to `pyproject.toml`, most notable change is
    the stuff added to the dev Poetry dependency group is no longer optional.
- `pyproject.toml`:
  - Simplified the dependency constrains for `networkx` as this was causing
    problems with tox, as tox was running pip install with
    `'networkx<3.0.0,>=2.6.2; (python_version >= "3.7" and python_version <
    "3.8") and extra == "networkx"' 'networkx<3.0.0,>=2.8.8; (python_version >=
    "3.8" and python_version < "4.0") and extra == "networkx"'` and the `extra
    == "networkx"` here would never be true.
  - Added a `dev` poetry dependendcy group with everything that is needed for a
    sane development environment so that `poetry install` gets you a sane dev
    environment.
- `Taskfile.yml`:
  - Changed the commands so that everything works as before but now instead runs things with poetry.
  - Removed the legacy venv handling and replaced it with poetry equivalents.
- `tox.ini`:
  - Don't set nitpicky (`-n`) on the command line as it is being set
    conditionally on python version in `docs/conf.py` now.
@aucampia
Copy link
Author

aucampia commented Jan 3, 2023

May be worth waiting for: RDFLib#2192

@aucampia
Copy link
Author

aucampia commented Jan 3, 2023

May be worth waiting for: RDFLib#2192

Build finished and coverage is same as before: https://coveralls.io/builds/55615509

@jclerman jclerman merged commit 6aa9d6d into jclerman:switch-to-poetry Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants