Move dev dependencies from extras into poetry dep groups #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly so that poetry export is sane, but also because the extras should
not be polluted with things that peope who use the wheel don't want or use.
Other changes:
- GitHub Actions:
- Use `abatilo/actions-poetry` instead of `snok/install-poetry` as snok does
not work well on Windows.
- Install poetry before running tox so tox can call poetry.
- Fix caching on Windows and MacOS
- Add requirements files for poetry so its versions is managed by dependabot and
so that the same version can be used in multiple contexts.
- Add requirements file for Sphinx version used in readthedocs.
- The problem with nitpicky was related to sphinx 4, not to python 3.7. So
nitpicky is now disabled on Sphinx <= 5.
- `test/test_literal/test_xmlliterals.py`: Only run html5lib test when html5lib
is present.
- Check poetry and poetry.lock from `.pre-commit-config.yaml`.
- Changed `.readthedocs.yaml` to use poetry.
- Added an `extra` for lxml.
6 tasks
jclerman
reviewed
Jan 10, 2023
| @@ -23,3 +24,10 @@ repos: | |||
| pass_filenames: false | |||
| require_serial: true | |||
| args: ["."] | |||
| - repo: https://github.com/python-poetry/poetry | |||
There was a problem hiding this comment.
I did not know poetry had pre-commit hooks! Fascinating.
jclerman
reviewed
Jan 11, 2023
Rechecked it, I think it is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly so that poetry export is sane, but also because the extras should not be polluted with things that peope who use the wheel don't want or use.
Other changes:
abatilo/actions-poetryinstead ofsnok/install-poetryas snok does not work well on Windows.test/test_literal/test_xmlliterals.py: Only run html5lib test when html5lib is present..pre-commit-config.yaml..readthedocs.yamlto use poetry.extrafor lxml.