Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles conversion #5

Closed
wants to merge 1,222 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1222 commits
Select commit Hold shift + click to select a range
1ea679d
Merge pull request #74895 from CyrusNajmabadi/loaderProvider
CyrusNajmabadi Aug 26, 2024
4b77dc5
Merge remote-tracking branch 'upstream/main' into isolatedALC
CyrusNajmabadi Aug 26, 2024
01bba09
update configs for snap
dibarbet Aug 26, 2024
af2b409
Add related documents interface
CyrusNajmabadi Aug 26, 2024
ac1f843
Add remote side
CyrusNajmabadi Aug 26, 2024
bf2dd1c
Break things out
CyrusNajmabadi Aug 26, 2024
67ea275
Add remote impl
CyrusNajmabadi Aug 26, 2024
d58e435
Remote field
CyrusNajmabadi Aug 26, 2024
1f78cd8
Simplify
CyrusNajmabadi Aug 26, 2024
262a509
Callbacks
CyrusNajmabadi Aug 26, 2024
d0db45a
wrapping
CyrusNajmabadi Aug 26, 2024
649a76e
Double check document changes when dismiss rename
Cosifne Aug 26, 2024
d4f9e56
C# impl
CyrusNajmabadi Aug 26, 2024
1a018b5
in progress
CyrusNajmabadi Aug 26, 2024
2916771
Producer consumer
CyrusNajmabadi Aug 26, 2024
4226c0c
Simplify
CyrusNajmabadi Aug 26, 2024
35f8d96
Add test harness
CyrusNajmabadi Aug 26, 2024
6911ac0
test
CyrusNajmabadi Aug 26, 2024
c03680e
test export
CyrusNajmabadi Aug 26, 2024
0d334d6
Accessibility
CyrusNajmabadi Aug 26, 2024
05a2b3c
consistency
CyrusNajmabadi Aug 26, 2024
65c546d
consistency
CyrusNajmabadi Aug 26, 2024
3a99080
move
CyrusNajmabadi Aug 26, 2024
fd5703f
move
CyrusNajmabadi Aug 26, 2024
71a09a7
Add service
CyrusNajmabadi Aug 26, 2024
c65fa43
sort
CyrusNajmabadi Aug 27, 2024
e8a4899
consistentcy
CyrusNajmabadi Aug 27, 2024
193f4e4
move back
CyrusNajmabadi Aug 27, 2024
cf82fe6
internal
CyrusNajmabadi Aug 27, 2024
ce07de2
Remove last custom ref test assemblies (#74880)
jaredpar Aug 27, 2024
d4adac6
Merge pull request #74905 from Cosifne/dev/shech/RenameDismissedProblem
Cosifne Aug 27, 2024
4b2c772
Merge pull request #74471 from Orachor/coalesce-explicit-cast
CyrusNajmabadi Aug 27, 2024
9be2700
Update src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSy…
CyrusNajmabadi Aug 27, 2024
ca06773
Update src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGenera…
CyrusNajmabadi Aug 27, 2024
70c973c
Merge remote-tracking branch 'upstream/main' into isolatedALC
CyrusNajmabadi Aug 27, 2024
7c7a412
Merge pull request #74780 from CyrusNajmabadi/isolatedALC
CyrusNajmabadi Aug 27, 2024
e15839b
in progress
CyrusNajmabadi Aug 27, 2024
7401f5f
move
CyrusNajmabadi Aug 27, 2024
3314264
Merge remote-tracking branch 'upstream/main' into relatedDocuments
CyrusNajmabadi Aug 27, 2024
2f25c4d
Add test
CyrusNajmabadi Aug 27, 2024
94c4839
Add tests
CyrusNajmabadi Aug 27, 2024
5758964
Use InterceptorsNamespaces feature name instead of InterceptorsPrevie…
RikkiGibson Aug 27, 2024
8013e77
Add tests
CyrusNajmabadi Aug 27, 2024
9e990df
Move logic
CyrusNajmabadi Aug 27, 2024
ed4f78e
Remove logic
CyrusNajmabadi Aug 27, 2024
0d54341
Merge pull request #74904 from dotnet/dev/dibarbet/snap_17_12_p3
dibarbet Aug 27, 2024
00151b6
Docs
CyrusNajmabadi Aug 27, 2024
7b0129c
Docs
CyrusNajmabadi Aug 27, 2024
4e52ff7
Simplify
CyrusNajmabadi Aug 27, 2024
5cc06f9
Add comment
Cosifne Aug 27, 2024
f96221d
Move call to single function
Cosifne Aug 27, 2024
6181bc3
Put assert
Cosifne Aug 27, 2024
d57aff7
Fix
CyrusNajmabadi Aug 27, 2024
4112c21
Also let return handler use the function
Cosifne Aug 27, 2024
1562f12
Report nullable ctor warnings for struct primary constructors (#74844)
RikkiGibson Aug 27, 2024
672264b
Rename
Cosifne Aug 27, 2024
e1bf009
Update field keyword feature status (#74671)
jnm2 Aug 27, 2024
74e0537
Handler in progress
CyrusNajmabadi Aug 27, 2024
18cea13
Flesh out
CyrusNajmabadi Aug 27, 2024
c05f9a5
Add tests
CyrusNajmabadi Aug 27, 2024
c221d37
Fix build
Cosifne Aug 27, 2024
8e04e3a
Make host outputs public (#74750)
chsienki Aug 27, 2024
9a167e3
Add tests validating a particular scenario
CyrusNajmabadi Aug 27, 2024
d35453f
Put context in commit method
Cosifne Aug 27, 2024
73c2f85
Add parameter
Cosifne Aug 27, 2024
23a72fb
Put the method after the check
Cosifne Aug 27, 2024
29af7c3
Fix broken url (#74924)
RikkiGibson Aug 28, 2024
a3dbd80
Merge pull request #74906 from CyrusNajmabadi/relatedDocuments
CyrusNajmabadi Aug 28, 2024
79a4924
Merge remote-tracking branch 'upstream/main' into relatedDocumentsHan…
CyrusNajmabadi Aug 28, 2024
686d17a
revert
CyrusNajmabadi Aug 28, 2024
74d2fa5
Abs
CyrusNajmabadi Aug 28, 2024
dd14428
Avoid synthesizing incorrect `allows ref struct` delegate type parame…
jjonescz Aug 28, 2024
20dd630
in progress
CyrusNajmabadi Aug 28, 2024
f29717f
in progress
CyrusNajmabadi Aug 28, 2024
87731d3
Merge pull request #74921 from CyrusNajmabadi/addTests
CyrusNajmabadi Aug 28, 2024
842e645
Simplify equivalence comparers
CyrusNajmabadi Aug 28, 2024
2a48615
Work
CyrusNajmabadi Aug 28, 2024
6ce4397
- Updated LSP protocol types for document color support
mgoertz-msft Aug 28, 2024
63c1d9a
Fixes
CyrusNajmabadi Aug 28, 2024
d67b2dc
in progress
CyrusNajmabadi Aug 28, 2024
9589587
Simplify
CyrusNajmabadi Aug 28, 2024
acf067e
Add tests
CyrusNajmabadi Aug 28, 2024
24e5ea5
Simplify
CyrusNajmabadi Aug 28, 2024
edadee5
Merge pull request #74889 from Cosifne/dev/shech/TakeOnwershipWhenRename
Cosifne Aug 28, 2024
3deeaba
Fixes
CyrusNajmabadi Aug 28, 2024
d5dfe95
Merge pull request #74932 from CyrusNajmabadi/simplifyEquivalence
CyrusNajmabadi Aug 28, 2024
190e8dc
Merge branch 'main' into arrayROS
CyrusNajmabadi Aug 28, 2024
a02589d
Merge remote-tracking branch 'upstream/main' into relatedDocumentsHan…
CyrusNajmabadi Aug 28, 2024
348d5a8
Switch to early return
CyrusNajmabadi Aug 28, 2024
1c27d2a
Switch to early return
CyrusNajmabadi Aug 28, 2024
1ce5f40
tests
CyrusNajmabadi Aug 28, 2024
b86b464
tests
CyrusNajmabadi Aug 28, 2024
f0fed71
tests
CyrusNajmabadi Aug 28, 2024
aa5c2bc
tests
CyrusNajmabadi Aug 28, 2024
88a63a9
lint
CyrusNajmabadi Aug 28, 2024
24aa489
Fix
CyrusNajmabadi Aug 28, 2024
0ceb056
Merge pull request #74918 from CyrusNajmabadi/relatedDocumentsHandler
CyrusNajmabadi Aug 28, 2024
fc692f4
Fix
CyrusNajmabadi Aug 28, 2024
b08e2c7
inline
CyrusNajmabadi Aug 28, 2024
dc56774
Simplify
CyrusNajmabadi Aug 28, 2024
7628d99
Simplify
CyrusNajmabadi Aug 28, 2024
8da7e01
Merge latest changes from Main
mgoertz-msft Aug 28, 2024
14f5b27
Merge pull request #74934 from CyrusNajmabadi/arrayROS
CyrusNajmabadi Aug 29, 2024
251cbe9
Add IRelatedDocumentsService EA wrapper for Copilot
genlu Aug 29, 2024
70ca213
Use collection expressions
CyrusNajmabadi Aug 27, 2024
2e88ecb
Suppress obsolete IInitializationService warnings
mgoertz-msft Aug 29, 2024
cb94e16
Remove deleted folder from project file
CyrusNajmabadi Aug 29, 2024
239a873
Update src/Workspaces/CSharp/Portable/Microsoft.CodeAnalysis.CSharp.W…
CyrusNajmabadi Aug 29, 2024
c20a97e
remove from VB as well
CyrusNajmabadi Aug 29, 2024
1c3efe8
Merge branch 'removeFolder' of https://github.com/CyrusNajmabadi/rosl…
CyrusNajmabadi Aug 29, 2024
20897c9
Wait for solution to be loaded before initializing remote telemetry
CyrusNajmabadi Aug 29, 2024
b1bdaa1
Remove switch back
CyrusNajmabadi Aug 29, 2024
63d9bb2
Revert
CyrusNajmabadi Aug 29, 2024
8a0e682
Docs
CyrusNajmabadi Aug 29, 2024
ba9e683
Merge pull request #74939 from genlu/RelatedDocsEA
genlu Aug 29, 2024
4237ce3
Merge pull request #74920 from CyrusNajmabadi/collectionExprs
CyrusNajmabadi Aug 29, 2024
60a9a41
Update src/VisualStudio/Core/Def/Telemetry/VisualStudioWorkspaceTelem…
CyrusNajmabadi Aug 29, 2024
2142ecc
Update src/VisualStudio/Core/Def/Telemetry/VisualStudioWorkspaceTelem…
CyrusNajmabadi Aug 29, 2024
35faced
In progress
CyrusNajmabadi Aug 29, 2024
6aafc1b
Delay until client is first created
CyrusNajmabadi Aug 29, 2024
0117b1b
Revert
CyrusNajmabadi Aug 29, 2024
8e19a10
Fix
CyrusNajmabadi Aug 29, 2024
2cadd1c
Simplify
CyrusNajmabadi Aug 29, 2024
c39d594
Merge pull request #74933 from mgoertz-msft/dev/mgoertz/color
dibarbet Aug 29, 2024
d8786e3
Merge pull request #74942 from CyrusNajmabadi/removeFolder
CyrusNajmabadi Aug 29, 2024
5349b2b
WithCancellation
CyrusNajmabadi Aug 29, 2024
268b43e
Don't have the syncer actually cause the remote side to be created
CyrusNajmabadi Aug 29, 2024
1787d41
Ensure cancellation is synchronous
CyrusNajmabadi Aug 29, 2024
64ba4d8
Simpler
CyrusNajmabadi Aug 29, 2024
f58fdda
Break into parts
CyrusNajmabadi Aug 29, 2024
a6f7559
Update src/VisualStudio/Core/Def/Remote/VisualStudioRemoteHostClientP…
CyrusNajmabadi Aug 29, 2024
11e97be
Update src/Workspaces/Remote/ServiceHub/Services/ProcessTelemetry/Rem…
CyrusNajmabadi Aug 29, 2024
95bd317
Simplify
CyrusNajmabadi Aug 29, 2024
c824c47
Simplify
CyrusNajmabadi Aug 29, 2024
8036f30
Simplify
CyrusNajmabadi Aug 29, 2024
fb5489a
Simplify
CyrusNajmabadi Aug 29, 2024
642af4d
Simplify
CyrusNajmabadi Aug 29, 2024
ccbc6ea
Simplify
CyrusNajmabadi Aug 29, 2024
281b383
Wrap
CyrusNajmabadi Aug 29, 2024
f4809a3
REvert
CyrusNajmabadi Aug 29, 2024
2834b34
REvert
CyrusNajmabadi Aug 29, 2024
ea415c3
REvert
CyrusNajmabadi Aug 29, 2024
2c190c4
REvert
CyrusNajmabadi Aug 29, 2024
bcaf720
REvert
CyrusNajmabadi Aug 29, 2024
3c4758f
REvert
CyrusNajmabadi Aug 29, 2024
253c5b6
REvert
CyrusNajmabadi Aug 29, 2024
014e61c
REvert
CyrusNajmabadi Aug 29, 2024
37a19ab
Simplify
CyrusNajmabadi Aug 29, 2024
1d49eb0
Merge pull request #74944 from CyrusNajmabadi/waitForLoad
CyrusNajmabadi Aug 30, 2024
2805273
Merge pull request #74948 from CyrusNajmabadi/synchronousCancel
CyrusNajmabadi Aug 30, 2024
9907b79
Collection expressions: use conversion to check for ICollection<T> fo…
cston Aug 30, 2024
b26088a
in progress
CyrusNajmabadi Aug 30, 2024
1f21f90
in progress
CyrusNajmabadi Aug 30, 2024
ca4f838
fix
CyrusNajmabadi Aug 30, 2024
f126e91
Move more
CyrusNajmabadi Aug 30, 2024
e21071f
in progress
CyrusNajmabadi Aug 30, 2024
80882c1
Fix layering
CyrusNajmabadi Aug 30, 2024
0ee9423
Fixes
CyrusNajmabadi Aug 30, 2024
de44b14
Tests
CyrusNajmabadi Aug 30, 2024
0304ab1
Tests
CyrusNajmabadi Aug 30, 2024
3de525a
More tests
CyrusNajmabadi Aug 30, 2024
5549b10
More tests
CyrusNajmabadi Aug 30, 2024
d385a5f
More tests
CyrusNajmabadi Aug 30, 2024
7a4dacb
More tests
CyrusNajmabadi Aug 30, 2024
e9a4f91
Fix tests
CyrusNajmabadi Aug 30, 2024
c5d6d27
building
CyrusNajmabadi Aug 30, 2024
efe946f
share code
CyrusNajmabadi Aug 30, 2024
02b9a11
Remoive
CyrusNajmabadi Aug 30, 2024
8f1bbea
Remoive
CyrusNajmabadi Aug 30, 2024
743d0ce
Remoive
CyrusNajmabadi Aug 30, 2024
20e8927
Remoive
CyrusNajmabadi Aug 30, 2024
2dee181
Remoive
CyrusNajmabadi Aug 30, 2024
8f32abb
Remoive
CyrusNajmabadi Aug 30, 2024
080e217
Remoive
CyrusNajmabadi Aug 30, 2024
cd81fe7
Update src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/Wor…
CyrusNajmabadi Aug 30, 2024
6e25f38
ublblock
CyrusNajmabadi Aug 30, 2024
1ecf196
Update PublishData after vs snap
dibarbet Aug 30, 2024
7f4f21c
Use ignore case to fix analyzer reloadong in devkit
dibarbet Aug 30, 2024
2932b83
Update PublishData.json
dibarbet Aug 30, 2024
291b5df
Merge pull request #74961 from dotnet/dibarbet-patch-1
dibarbet Aug 30, 2024
a4822c7
Merge pull request #74963 from dibarbet/fix_analyzer_reloading_devkit
dibarbet Aug 31, 2024
cb6ef38
Add ProjectInfo.WithId public API (#74664)
tmat Aug 31, 2024
8e763eb
Fix
CyrusNajmabadi Aug 31, 2024
ac1968d
Add NFW tracking to Solution.RemoveProjectReference (#74965)
ToddGrun Aug 31, 2024
5cba0ce
Merge pull request #74958 from CyrusNajmabadi/codeStyle
CyrusNajmabadi Aug 31, 2024
b19ecd7
Move to the real System.ValueTuple ref (#74936)
jaredpar Sep 2, 2024
935befe
Allow ref enumerators in async/iterator methods (#74800)
jjonescz Sep 2, 2024
c6a0795
Optimize single spread collection expression for `List<T>` (#74769)
DoctorKrolic Sep 3, 2024
5b1d55d
Expose Go To Impl and Spell Check to Razor
davidwengier Sep 3, 2024
4619ed7
Partial properties: duplicate membersByName before merging accessors …
cston Sep 3, 2024
3bd322d
[main] Update dependencies from dotnet/arcade (#74835)
dotnet-maestro[bot] Sep 3, 2024
a59061f
Revert "Load analyzers and generators in isolated ALCs in our OOP pro…
333fred Sep 4, 2024
077642f
Merge pull request #74978 from davidwengier/CohostImplemenationAndSpe…
davidwengier Sep 4, 2024
82ea19e
Mark "ref struct interfaces" as shipped in C# 13 (#74991)
jcouv Sep 4, 2024
9fbfe9f
Merge pull request #74985 from dotnet/revert-74780-isolatedALC
333fred Sep 4, 2024
7831d50
Ignore workspaces that do not have IEditAndContinueWorkspaceService (…
tmat Sep 4, 2024
979d7b2
Find first potential editorconfig when trying to synchronize (#74986)
ryzngard Sep 4, 2024
9f86520
Avoid BuildHost crash in Mono due to missing types (#74994)
jaredpar Sep 5, 2024
3b7995d
Remove toolset compiler workarounds (#74990)
jjonescz Sep 5, 2024
71134f1
Re-enable double-to-integer conversion tests (#74980)
jjonescz Sep 5, 2024
07d7a21
Fix typo incremental-generators.cookbook.md (#74642)
elisauhura Sep 5, 2024
2ff1a47
Fixup partial property API usage (#74951)
RikkiGibson Sep 5, 2024
8ce8103
Remove debug-only assert method (#74996)
333fred Sep 5, 2024
1ac3ea0
Fix exception case in compiler resolver (#75000)
jaredpar Sep 5, 2024
d662cde
[main] Update dependencies from dotnet/arcade (#74988)
dotnet-maestro[bot] Sep 5, 2024
43fbad7
CodeQL suppressions (#75003)
jaredpar Sep 5, 2024
6ad9d42
Fix IOperation debugging experience (#74997)
jjonescz Sep 6, 2024
1ce264c
Test attribute function pointer execution on net9 (#74999)
jjonescz Sep 6, 2024
139f845
Remove the cancellation token from the calculation of InProgressState…
ToddGrun Sep 6, 2024
f71c569
Make sure the solution snapshot has all source-generated documents up…
tmat Sep 6, 2024
fa7bb6d
Convert RudeEditDiagnostic to Diagnostic in EmitSolutionUpdateAsync
tmat Sep 7, 2024
bd5c00e
Fix typo in ProjectCodeModelFactory.ProcessNextDocumentBatchAsync (#7…
ToddGrun Sep 8, 2024
80c329b
Preserve trailing trivia when replacing method with property
Sep 9, 2024
b449a7c
Preserve trailing trivia when replacing method with property
Sep 9, 2024
bbcec65
Merge pull request #75027 from Orachor/missing-eol
CyrusNajmabadi Sep 9, 2024
2985e58
Use numbered lists in `IOperation` documentation (#75016)
DoctorKrolic Sep 9, 2024
dca25b1
Use ordinal ignore case for opening pdb source documents
dibarbet Sep 9, 2024
fd1cc2d
Merge pull request #75030 from dibarbet/fix_comparison
dibarbet Sep 9, 2024
a69841b
Handle infinite cycles through params collection initializers (#74899)
jjonescz Sep 10, 2024
85ec699
Report source generator failures in Hot Reload diagnostics (#75029)
tmat Sep 10, 2024
d975a01
Expose sourcelink option to VSCode
dibarbet Sep 10, 2024
e731081
Fix issue where closing sourcelink document threw if not opened
dibarbet Sep 10, 2024
59b5770
Fix error opening the same sourcelink file
dibarbet Sep 10, 2024
7274c18
Merge pull request #75044 from dibarbet/expose_source_link_option
dibarbet Sep 10, 2024
3aa6e3b
Merge pull request #75046 from dibarbet/fix_sourcelink_not_opened
dibarbet Sep 10, 2024
aaa2668
Update dependencies from https://github.com/dotnet/arcade build 20240…
dotnet-maestro[bot] Sep 11, 2024
9941c1f
Allow suppressing nullability warnings in more ref scenarios (#74498)
jjonescz Sep 11, 2024
6de8947
Remove MS.CA.Test.Resources.Proprietary PackageReference (#75037)
jaredpar Sep 11, 2024
21efe0e
Configure release/vscode branch for nuget publishing
dibarbet Sep 11, 2024
7b75058
Semantic snippets: handle case with inline statement snippets before …
DoctorKrolic Sep 11, 2024
d25d215
Fix preview refresh on selection for enum flags checkboxes
dibarbet Sep 11, 2024
fcafea5
Merge pull request #75053 from dibarbet/fix_preview_checkbox
dibarbet Sep 11, 2024
dbe7583
Merge pull request #75059 from dotnet/dibarbet-patch-1
dibarbet Sep 11, 2024
58da55d
Add a test observing lack of an issue. (#75057)
AlekseyTs Sep 11, 2024
09ef0c0
docs: Correct SDK version in documentation to match global.json (#75038)
deepakrathore33 Sep 11, 2024
ece0b48
Lock translation of strings used to demonstrate identifier naming styles
JoeRobich Sep 12, 2024
0654505
Fix stack adjustment when emitting stackalloc (#75042)
jjonescz Sep 12, 2024
eaa213f
Merge pull request #75065 from dotnet/dev/jorobich/lock-translation
JoeRobich Sep 12, 2024
2149908
Remove additional Gitter link (#75086)
333fred Sep 12, 2024
f56229e
Merge remote-tracking branch 'origin/main' into HEAD
jcouv Sep 12, 2024
f2d4c27
Resolve merge conflicts
jcouv Sep 12, 2024
87df3d7
Merge pull request #75090 from jcouv/merge-master
jcouv Sep 17, 2024
59c9d03
WIP on roles conversions
jcouv Jul 29, 2024
1b65067
WIP
jcouv Sep 16, 2024
faf1a4b
More nullable conversion tests
jcouv Sep 17, 2024
616036e
Standard conversion scenarios
jcouv Sep 18, 2024
74566bf
Collection expressions
jcouv Sep 18, 2024
8d7b7a6
Punt collection expressions, spot null literal conversion issue
jcouv Sep 19, 2024
229e72a
Fix null literal scenario
jcouv Sep 19, 2024
9aa9164
Default literal conversion
jcouv Sep 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
91 changes: 68 additions & 23 deletions .github/policies/resourceManagement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ where:
configuration:
resourceManagementConfiguration:
scheduledSearches:

- description: Close "Need More Info" Issues
frequencies:
- hourly:
Expand All @@ -23,8 +24,12 @@ configuration:
- closeIssue
- addReply:
reply: "Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it. "

eventResponderTasks:
- if:

- description: Auto-approve auto-merge PRs
triggerOnOwnActions: false
if:
- payloadType: Pull_Request
- isPullRequest
- labelAdded:
Expand All @@ -38,9 +43,10 @@ configuration:
then:
- approvePullRequest:
comment: Auto-approval
description: Auto-approve auto-merge PRs

- description: Auto-approve maestro PRs
triggerOnOwnActions: false
- if:
if:
- payloadType: Pull_Request
- isPullRequest
- isActivitySender:
Expand All @@ -55,9 +61,10 @@ configuration:
then:
- approvePullRequest:
comment: Auto-approve
description: Auto-approve maestro PRs
triggerOnOwnActions: false
- if:

- description: Milestone tracking
triggerOnOwnActions: true
if:
- payloadType: Pull_Request
- isPullRequest
- or:
Expand All @@ -72,9 +79,10 @@ configuration:
then:
- addMilestone:
milestone: Next
description: Milestone tracking
triggerOnOwnActions: true
- if:

- description: Auto-approve OneLoc PRs
triggerOnOwnActions: false
if:
- payloadType: Pull_Request
- isPullRequest
- isActivitySender:
Expand All @@ -88,9 +96,10 @@ configuration:
then:
- addLabel:
label: auto-merge
description: Auto-approve OneLoc PRs

- description: Remove "Need More Info" on comment
triggerOnOwnActions: false
- if:
if:
- payloadType: Issue_Comment
- isIssue
- isOpen
Expand All @@ -101,9 +110,10 @@ configuration:
label: untriaged
- removeLabel:
label: Need More Info
description: Remove "Need More Info" on comment

- description: Label Community Pull Requests
triggerOnOwnActions: false
- if:
if:
- payloadType: Pull_Request
- isPullRequest
- isAction:
Expand Down Expand Up @@ -142,13 +152,45 @@ configuration:
then:
- addLabel:
label: Community
description: Label Community Pull Requests

- description: Adds "VSCode" tag on PRs which may affect C# extension.
triggerOnOwnActions: false
if:
- payloadType: Pull_Request
- isPullRequest
- filesMatchPattern:
pattern: 'src/(Analyzers|CodeStyle|Features|LanguageServer|Workspaces)/.*\.(cs|vb)$'
matchAny: true
- and:
- not:
isActivitySender:
user: dotnet-bot
issueAuthor: False
- not:
isActivitySender:
user: github-actions
issueAuthor: False
- or:
- isAction:
action: Opened
- isAction:
action: Synchronize
- and:
- not:
hasLabel:
label: VSCode
then:
- addLabel:
label: VSCode

- description: Add "Needs UX Triage" on PRs
triggerOnOwnActions: false
- if:
if:
- payloadType: Pull_Request
- isPullRequest
- filesMatchPattern:
pattern: '[xX][aA][mM][lL]$'
pattern: '.*\.[xX][aA][mM][lL]$'
matchAny: true
- and:
- not:
hasLabel:
Expand Down Expand Up @@ -187,12 +229,15 @@ configuration:
then:
- addLabel:
label: Needs UX Triage
description: Add "Needs UX Triage" on PRs

- description: Adds "Needs API Review" on PRs that touch public APIs
triggerOnOwnActions: false
- if:
if:
- payloadType: Pull_Request
- isPullRequest
- filesMatchPattern:
pattern: .*/PublicAPI\.(Shipped|Unshipped)\.txt
pattern: '.*/PublicAPI\.(Shipped|Unshipped)\.txt'
matchAny: true
- not:
isActivitySender:
user: dotnet-bot
Expand All @@ -214,9 +259,10 @@ configuration:
label: Needs API Review
- addReply:
reply: This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.
description: Adds "Needs API Review" on PRs that touch public APIs

- description: Close automatically generated PR tagger issues
triggerOnOwnActions: false
- if:
if:
- payloadType: Issues
- isIssue
- hasLabel:
Expand All @@ -226,7 +272,6 @@ configuration:
isRegex: False
then:
- closeIssue
description: Close automatically generated PR tagger issues
triggerOnOwnActions: false

onFailure:
onSuccess:
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
.packages/
.nuget/
.complog/
/MSBuild_Logs/

# Enable "build/" folder in the NuGet Packages folder since NuGet packages use it for MSBuild targets
!packages/*/build/
Expand Down
10 changes: 9 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,13 @@
"azure-pipelines.customSchemaFile": ".vscode/dnceng-schema.json",
"dotnet.defaultSolution": "Roslyn.sln",
"dotnet.completion.showCompletionItemsFromUnimportedNamespaces": true,
"dotnet.testWindow.disableAutoDiscovery": true
"dotnet.testWindow.disableAutoDiscovery": true,
"dotnet.testWindow.disableBuildOnRefresh": true,
"cSpell.words": [
"Nerdbank",
"NETCOREAPP",
"Unregistration",
"Unregistrations",
"Xunit"
]
}
5 changes: 4 additions & 1 deletion .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"msbuild",
"-p:RunAnalyzersDuringBuild=false",
"-p:GenerateFullPaths=true",
"-tl:off",
"src/Compilers/CSharp/csc/AnyCpu/csc.csproj"
],
"problemMatcher": "$msCompile",
Expand All @@ -62,6 +63,7 @@
"build",
"-p:RunAnalyzersDuringBuild=false",
"-p:GenerateFullPaths=true",
"-tl:off",
"Compilers.slnf"
],
"problemMatcher": "$msCompile",
Expand All @@ -75,6 +77,7 @@
"build",
"-p:RunAnalyzersDuringBuild=false",
"-p:GenerateFullPaths=true",
"-tl:off",
"Roslyn.sln"
],
"problemMatcher": "$msCompile",
Expand Down Expand Up @@ -145,7 +148,7 @@
"build",
"-c",
"Debug",
"src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj"
"src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj"
],
"problemMatcher": "$msCompile",
"group": "build"
Expand Down
3 changes: 1 addition & 2 deletions Directory.Build.rsp
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
# Workaround for https://github.com/dotnet/sdk/issues/41791
-p:_IsDisjointMSBuildVersion=false
# This file intentionally left blank to avoid accidental import during build.
Loading