Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(locale): add use-locale #2642

Merged
merged 20 commits into from
Nov 14, 2023
Merged

chore(locale): add use-locale #2642

merged 20 commits into from
Nov 14, 2023

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Nov 7, 2023

这个 PR 做了什么? (简要描述所做更改)

将 translate 方法从 createComponent 中剥离,作为 useLocale 方法提供。
计划废弃 createComponent 方法。

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9edced3) 84.99% compared to head (4d3eb49) 85.02%.

Files Patch % Lines
src/packages/__VUE/uploader/type.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2642      +/-   ##
==========================================
+ Coverage   84.99%   85.02%   +0.02%     
==========================================
  Files         151      152       +1     
  Lines       20928    20999      +71     
  Branches     2354     2352       -2     
==========================================
+ Hits        17788    17854      +66     
- Misses       3135     3140       +5     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu added this to the v4.2.2 milestone Nov 9, 2023
@eiinu eiinu merged commit 272ce3d into jd-opensource:v4 Nov 14, 2023
@eiinu eiinu deleted the feat-use-locale branch November 14, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant