Add new driver for trustme #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trustme driver provides TLS certificates for both client and server side on the go. The certificates and keys are created in the tempdir and their path pushed to environment variables. Signed-off-by: Moisés Guimarães de Medeiros <[email protected]>
jd
requested changes
Dec 2, 2020
| @@ -185,7 +185,7 @@ def expand_urls_var(url): | |||
|
|
|||
| putenv("PID", str(os.getpid())) | |||
| putenv("DAEMON", daemon) | |||
| url = os.getenv(driver.env_prefix + "_URL") | |||
| url = os.getenv(driver.env_prefix + "_URL", "") | |||
There was a problem hiding this comment.
This seems unrelated to this PR. If it's needed, can you put that into another PR?
There was a problem hiding this comment.
will do, it was crashing cause the new driver didn't put an env variable prefixed with _URL.
| @@ -251,7 +251,7 @@ def _cleanup(signum, frame): | |||
| signal.signal(signal.SIGPIPE, signal.SIG_IGN) | |||
| signal.pause() | |||
| else: | |||
| url = driver.env['%s_URL' % driver.env_prefix] | |||
| url = driver.env.get('%s_URL' % driver.env_prefix, "") | |||
| @@ -4,4 +4,5 @@ pbr | |||
| jinja2 | |||
| fixtures | |||
| psutil | |||
| trustme | |||
There was a problem hiding this comment.
This should come with a flavor, not in base deps.
| def get_options(cls): | ||
| return [ | ||
| { | ||
| "param_decls": ["--client_identity"], |
There was a problem hiding this comment.
Suggested change
| "param_decls": ["--client_identity"], | |
| "param_decls": ["--client-identity"], |
sounds more common
| "to use when checking identity.", | ||
| }, | ||
| { | ||
| "param_decls": ["--server_identity"], |
There was a problem hiding this comment.
Suggested change
| "param_decls": ["--server_identity"], | |
| "param_decls": ["--server-identity"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trustme driver provides TLS certificates for both client and
server side on the go. The certificates and keys are created in
the tempdir and their path pushed to environment variables.
Signed-off-by: Moisés Guimarães de Medeiros [email protected]