Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resets body, method and content-length when redirected #15

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Resets body, method and content-length when redirected #15

merged 2 commits into from
Dec 12, 2022

Conversation

maccyber
Copy link
Contributor

@maccyber maccyber commented Dec 11, 2022 •
edited
Loading

This needs to be done, so that the request to the redirected URL is a GET and not with body nor content-length

ref. https://github.com/valeriangalliat/fetch-cookie/blob/master/src/index.ts#L176-L178

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jd1378 jd1378 merged commit 7f8a1ef into jd1378:main Dec 12, 2022
@jd1378
Copy link
Owner

jd1378 commented Dec 12, 2022 •
edited
Loading

thanks, it makes sense
I'll try to add a test for it as well before releasing the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maccyber @jd1378