Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the possibility to set a HTTP proxy, using environment variables. It answers to the following issue (and implemented a solution using the advice given here) : Is there a way to set proxy settings ?
So from now, you can set
GLOBAL_AGENT_HTTPS_PROXY
if you have proxy needs, and it will work 👌Pull Request Process
Additionnal notes
The solution implemented uses 'global-agent
, but it looks like it didn't need a
npm install global-agentto add it to the
package.json, I suppose it's included in another lib used by the package (maybe
got` ?). If you want me to add it "in case of", I can do that !Thanks in advance for checking that PR 😄
closes #2014