Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] css modules support localidentname #61

Closed
beanlee opened this issue Sep 3, 2020 · 1 comment · Fixed by #62
Closed

[Feature Request] css modules support localidentname #61

beanlee opened this issue Sep 3, 2020 · 1 comment · Fixed by #62
Assignees
@beanlee

Comments

@beanlee
Copy link
Member

beanlee commented Sep 3, 2020

🌈 Feature

https://webpack.js.org/loaders/css-loader/#localidentname

目前 Rocketact 支持 css modules 功能，仅支持所有走默认选项，目前项目需求支持 localidentname 可配置，考虑内置还是使用 plugin 方式修改。
@beanlee
Copy link
Member Author

beanlee commented Sep 3, 2020 •
edited
Loading

参考 create-react-app 配置，基本确定使用 [name]_[local]__[hash:base64:5] ex. index-module_title__2oVtp

参见 https://github.com/facebook/create-react-app/blob/master/packages/react-dev-utils/getCSSModuleLocalIdent.js

beanlee added a commit to beanlee/rocketact that referenced this issue Sep 3, 2020
@beanlee
feat(scripts modules.ts): css modules localidentname config
077a847 
fix jdf2e#61
@beanlee beanlee mentioned this issue Sep 3, 2020
Merged
@beanlee beanlee self-assigned this Sep 3, 2020
@loveky loveky closed this as completed in #62 Sep 3, 2020
loveky added a commit that referenced this issue Sep 3, 2020
@loveky
Merge pull request #62 from beanlee/master
af80cf6 
fix #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beanlee beanlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #61 beanlee/rocketact
1 participant
@beanlee