Prevent explorer element edition from ending between rendering calls. F…

…ixes microsoft#72626
jeanp413 · Apr 27, 2019 · 5cceb7f · 5cceb7f
1 parent 750680d
commit 5cceb7f
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts b/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts
@@ -218,20 +218,22 @@ export class FilesRenderer implements ITreeRenderer<ExplorerItem, FuzzyScore, IF
 		inputBox.focus();
 		inputBox.select({ start: 0, end: lastDot > 0 && !stat.isDirectory ? lastDot : value.length });
 
-		const done = once(async (success: boolean) => {
+		const done = once(async (success: boolean, fromDOMEvent: boolean) => {
 			label.element.style.display = 'none';
 			const value = inputBox.value;
 			dispose(toDispose);
 			container.removeChild(label.element);
-			// Timeout: once done rendering only then re-render #70902
-			setTimeout(() => editableData.onFinish(value, success), 0);
+			if (fromDOMEvent) {
+				// Timeout: once done rendering only then re-render #70902
+				setTimeout(() => editableData.onFinish(value, success), 0);
+			}
 		});
 
 		let ignoreDisposeAndBlur = true;
 		setTimeout(() => ignoreDisposeAndBlur = false, 100);
 		const blurDisposable = DOM.addDisposableListener(inputBox.inputElement, DOM.EventType.BLUR, () => {
 			if (!ignoreDisposeAndBlur) {
-				done(inputBox.isInputValid());
+				done(inputBox.isInputValid(), true);
 			}
 		});
 
@@ -240,10 +242,10 @@ export class FilesRenderer implements ITreeRenderer<ExplorerItem, FuzzyScore, IF
 			DOM.addStandardDisposableListener(inputBox.inputElement, DOM.EventType.KEY_DOWN, (e: IKeyboardEvent) => {
 				if (e.equals(KeyCode.Enter)) {
 					if (inputBox.validate()) {
-						done(true);
+						done(true, true);
 					}
 				} else if (e.equals(KeyCode.Escape)) {
-					done(false);
+					done(false, true);
 				}
 			}),
 			blurDisposable,
@@ -252,10 +254,8 @@ export class FilesRenderer implements ITreeRenderer<ExplorerItem, FuzzyScore, IF
 		];
 
 		return toDisposable(() => {
-			if (!ignoreDisposeAndBlur) {
-				blurDisposable.dispose();
-				done(false);
-			}
+			blurDisposable.dispose();
+			done(false, false);
 		});
 	}