Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reading gzipped WARC files #10

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Implement reading gzipped WARC files #10

merged 1 commit into from
Jul 11, 2020

Conversation

jhwgh1968
Copy link
Collaborator

Implements the read half of #8.

Copy link
Owner

@jedireza jedireza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good. I test drove this and it worked as expected. I did see warnings about the unused imports. Let's drop those and we can land this.

warning: unused imports: `CONTENT_LENGTH`, `WARC_DATE`, `WARC_RECORD_ID`, `WARC_TYPE`
 --> src/warc_types.rs:3:21
  |
3 | use crate::header::{CONTENT_LENGTH, WARC_DATE, WARC_RECORD_ID, WARC_TYPE};
  |                     ^^^^^^^^^^^^^^  ^^^^^^^^^  ^^^^^^^^^^^^^^  ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

src/warc_types.rs Outdated Show resolved Hide resolved
@jhwgh1968
Copy link
Collaborator Author

Fixed, @jedireza!

@jedireza jedireza merged commit 5ed2c6b into jedireza:master Jul 11, 2020
@jedireza
Copy link
Owner

Thanks again. Published as v0.2.1.

@jhwgh1968 jhwgh1968 deleted the gzip_read branch July 17, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants