fix: 安卓环境Go Time 固定UTC时区，通过时区获取偏移量修正时区 #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
根据你的提示已经做了修改， tZ 参数不设置默认值, 根据环境获取时区字符串, 传入 tZ 则用自定义的时区 |
本地环境已经做了验证
|
jeessy2
reviewed
Oct 17, 2024
main.go
Outdated
Comment on lines
60
to
62
| // 修正安卓时区 | ||
| var timeZone = flag.String("tZ", "", "fix Android Time Zone") | ||
|
|
There was a problem hiding this comment.
只有android才有问题吧，可以不要此参数，判断是android才自动改。
There was a problem hiding this comment.
是的目前发现只有安卓会出现这个问题
There was a problem hiding this comment.
只有android才有问题吧，可以不要此参数，判断是android才自动改。
加入参数是为了，让用户可以自定义选择时区
There was a problem hiding this comment.
那可以不用这个参数，简单点
好的
There was a problem hiding this comment.
判断是android，直接用那段代码，不搞复杂了
已做修改
jeessy2
reviewed
Oct 17, 2024
main.go
Outdated
Comment on lines
81
to
84
| // func initLocal() { | ||
| // // TODO(elias.naur): getprop persist.sys.timezone | ||
| // localLoc = *UTC | ||
| // } |
There was a problem hiding this comment.
测了正常吧？
我这边基于 我的车机adb 环境测试是没问题的
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复安卓环境运行ddns-go 少8小时的问题。
[go/src/time/zoneinfo_android.go]
func initLocal() {
// TODO(elias.naur): getprop persist.sys.timezone
localLoc = *UTC
}
zoneinfo_android.go 固定了 localLoc 为 UTC，所以设置环境变量无效。
设置启动参数 tZ, 默认从环境获取时区字符串, 判断当前GOOS为 android 调用 FixTimezone 进行时区修正