Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a number from starting a lambda capture #423

Closed
wants to merge 3 commits into from

Conversation

matter123
Copy link
Collaborator

Fixes: #412
Related: microsoft/vscode#85385

@matter123
Copy link
Collaborator Author

@valentjn

This latest commit prohibits ; or ] (in addition to the previously added [ from following a lambada capture.

Screen Shot 2019-11-25 at 08 47 37

@matter123
Copy link
Collaborator Author

Closing as resolved in v1.14.15

@matter123 matter123 closed this Dec 30, 2019
@valentjn
Copy link

@matter123 I don't think this is resolved. I just tested it with v1.14.16 and it only seems to resolve it when there's a number in the square brackets, not letters.

Screenshots of the above example - without Better C++ Syntax (VS Code 1.41.0, Linux x64):
Screenshot_20191230_094355

With Better C++ Syntax v1.14.16:
Screenshot_20191230_094316

The comment on line 3 is formatted correctly, but not the comment on line 10.

@matter123 matter123 reopened this Dec 30, 2019
@matter123
Copy link
Collaborator Author

Thanks, didnt catch that.

@matter123
Copy link
Collaborator Author

Closing in favor of #437.

@matter123 matter123 closed this Jan 9, 2020
@matter123 matter123 deleted the cpp/fix/#412 branch January 24, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with comments between array declaration
2 participants