You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.
This is a follow-up to my issue at #187 which I've tested by now via the latest release
Describe the bug
When playback ends at the end of a song queue, jellyfin counts the playback for that song twice even though playback has stopped. This can be seen via dashboard and either within the Playback Reporting or the native jellyfin reporting
To Reproduce
Steps to reproduce the behavior:
Using v0.12.0 add some songs to the queue (I haven't tested if if also occurs with one song, but with 2+ songs it will occur)
Having scrobbling active, play them and wait for the last song to have finished playing
After the queue ends, watch the dashboard. You will see that the last played song seems to be running again. Verify that both reporting methods show the last song being played twice without having repeat active
Expected behavior
When playback stops, the status sent to jellyfin should also reflect that nothing is played anymore
Screenshots
Here's a screenshot of the native reporting. Notice that the song immediately is considered to be playing again, but playback only stops after 6 minutes (the song is 3:44 min long)
Here's the view from within the Playback Reporting Plugin (the same from my other issue). Notice that the playtime is also off compared to the real song (the one hour difference in time is from timezones, seems that the native reporting is using UTC, while I am in UTC+1 and it's currently 7:32am here)
Desktop (please complete the following information):
OS: Windows 11
Version: 0.12.0
Additional context
I have noticed that the status reported to jellyfin seem to lag a bit behind the status seen in sonixd. One song wasn't even reported properly, I toggled scrobbling and then it somehow worked again. While I am not really good enough to do something in code, I'll gladly provide any info you need and I can test stuff before release
The text was updated successfully, but these errors were encountered:
I made some additional changes to the player which should resolve the following:
No longer sends another play request to the server after the last song ends. This was occurring because I didn't add a check to make sure to only send it if the player has the status of "PLAYING". You see that playback continues for 6 minutes because there's no "STOP" being sent to the "ghost" player.
The player time (on the dashboard) shouldn't lag behind as much anymore. Since there's now a 5 second timeout after the song starts before the play request is sent, it was sending a position of 0, which has now been changed to 5 to match the time properly. It may still be off +-1 second but that's normal.
Player should now also properly handle pause/resume. When I was making changes to the scrobbling, I seem to have removed and forgot to re-add some logic when the player pauses and resumes. That meant that once the player was paused during playback, resuming would not resume it on Jellyfin since it was stuck until the next song.
Going to push a hotfix release with these changes shortly.
One song wasn't even reported properly
Let me know if after these changes this still occurs or if there are any other issues.
This is a follow-up to my issue at #187 which I've tested by now via the latest release
Describe the bug
When playback ends at the end of a song queue, jellyfin counts the playback for that song twice even though playback has stopped. This can be seen via dashboard and either within the Playback Reporting or the native jellyfin reporting
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When playback stops, the status sent to jellyfin should also reflect that nothing is played anymore
Screenshots
Here's a screenshot of the native reporting. Notice that the song immediately is considered to be playing again, but playback only stops after 6 minutes (the song is 3:44 min long)
Here's the view from within the Playback Reporting Plugin (the same from my other issue). Notice that the playtime is also off compared to the real song (the one hour difference in time is from timezones, seems that the native reporting is using UTC, while I am in UTC+1 and it's currently 7:32am here)
Desktop (please complete the following information):
Additional context
I have noticed that the status reported to jellyfin seem to lag a bit behind the status seen in sonixd. One song wasn't even reported properly, I toggled scrobbling and then it somehow worked again. While I am not really good enough to do something in code, I'll gladly provide any info you need and I can test stuff before release
The text was updated successfully, but these errors were encountered: