Confusing Exit Behavior on macOS

[ghost]

Describe the bug
Contrary to common macOS apps, the exit button on the windows terminates the playback(practically restarts the app) while using the quit option in the menu closes the window while meataining the playback. They are behaving in the excat opposite manner IMO.

To Reproduce
Steps to reproduce the behavior:

1. Turn on [exit to tray] in the configuration.
2. Use the close button[X] on the window the close the window.

Expected behavior
Window closes without interrupting the playback.

Desktop (please complete the following information):

• OS: macOS
• Version: 10.13.6

Additional context
Add any other context about the problem here.

[jeffvli]

The macOS exit behavior was adjusted a couple months back by @zackslash to reflect the behavior you listed in #198.

I don't have a macOS device to test it myself, but @zackslash can you comment on whether or not you're experiencing the same exit issue here?

[zackslash]

Hey,

I've been trying to dig into this a bit further but ultimately could not replicate the issue.

The behaviour of these buttons is consistent for me after enabling 'exit to tray'.
Either quitting from the tray or the close button both result in the window closing and playback continuing.

@tomatgithub0 when you close the app (using the [X] button) does the app indicator (the black dot under the icon) dissapear from the tray?

If you can provide some information on this it it may give some indication as to what is going on.

I have recently spotted an issue where the app cannot be closed but that is the opposite of this reported issue, I am considering making some PRs to both fix that and add some good MacOS defaults (such as TitleBar Style) if the project is open to it, so it would be nice to get this issue fixed too.

[ghost]

Thank guys for looking at this.

Strangely enough, I just did a test again with [exit to tray] turned on, now it doesn't stop the music any more.

To answer your question, no, the indiator doesn't go away; in fact, it doesn't go away no matter what if you have [exit to tray] turned on, meaning there's no way to exit the app completely(Just like you mentioned). The only way is to turn off the option and quit the app.

The only reason I can think of is probably because it was a fresh install and the program hasn't fully initialized?

[ghost]

Correction:

I just noticed that the problem actually happens when the [exit to tray] is turned off.

Sorry!

[zackslash]

Thanks for the update.

I agree that [exit to tray] set to ON should be the default for MacOS since it's more inline with native behaviour. I can also understand how when [exit to tray] is off it could be confusing.

I think the two points below are a fair summary of the issues here:

• [exit to tray] is 'off' by default
• When [exit to tray] is 'on' the exit button in the system bar does not quit the app.