Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

MacOS exit to tray #268

Merged
merged 3 commits into from
Mar 18, 2022
Merged

MacOS exit to tray #268

merged 3 commits into from
Mar 18, 2022

Conversation

zackslash
Copy link
Contributor

This MR aims to provide a more native/intuitive behaviour in MacOS.

  • Enables 'exit to tray' by default in MacOS so music can continue in the background.
  • Fixes the 'Quit' menu bar item so that the app can be fully quit when in 'exit to tray' mode.
  • Fixes the app badge 'Quit' item so app can be fully quit from badge in 'exit to tray' mode.

Demonstration of fix: all settings set to default, app running in tray, opening and closing from system menus:

pr1.mov

Closes #264

Copy link
Owner

@jeffvli jeffvli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the app.exit() tray functionality on Windows as well and doesn't seem to break anything. Thanks.

@jeffvli jeffvli merged commit ceea806 into jeffvli:main Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Exit Behavior on macOS
2 participants