Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

Add Gruvbox-Dark and Gruvbox-Light themes #304

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Add Gruvbox-Dark and Gruvbox-Light themes #304

merged 6 commits into from
Apr 26, 2022

Conversation

MarshDeer
Copy link
Contributor

No description provided.

@jeffvli
Copy link
Owner

jeffvli commented Apr 22, 2022

Looks pretty good! A couple suggestions from me:

  1. Convert the color to a rgba value and add opacity for the colors.table.selectedRow color value since solid colors can make it harder to read what's currently selected.
    image
    image

  2. I think the colors.button.default.colorHover is broken (from my code side) so readability is difficult when hovering buttons on Gruvbox Light. I'm currently doing a full application rewrite so I probably won't be fixing it for the time being. I'd suggest choosing a different color and background hover color for the buttons so it's readable.
    image

@MarshDeer
Copy link
Contributor Author

Did the requested fixes and followed the workflow's recommendations re: adding , at the end of some lines.
Themes should hopefully be properly functional now!

@jeffvli
Copy link
Owner

jeffvli commented Apr 26, 2022

Thanks!

@jeffvli jeffvli merged commit 3bfd2fb into jeffvli:main Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants