-
-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
I appreciate the work to keep Sonixd up to date! Couple initial thoughts:
I can do a bit of testing on my end to see if I can get it working once I get a chance! |
The reason for using Yes, it is possible to re-enable remote, but given that electron-settings hasn't been updated a little over 2 years, it seemed like using a different store that actually uses IPC would be better. If you can confirm that NodeRT still works (or share how to get it properly set up), that would be lovely! I only have win11 (and had to zap my prior win 10 VM that was able to build sonixd...) |
This will also close #393 |
@kgarner7 I'm going to attempt to merge this in. I pushed a PR over to your fork to re-add in the nodert dependencies since they still build fine on the publish pipelines. Seems like only the tests are failing. |
Done! Glad to see sonixd still getting some love |
5dde42e
to
0dc0da9
Compare
I know there's work on a rewrite, but while this is still here, I'd like to at least provide updated packages.
Changes:
NOTE: I had to drop NodeRT because I could not get it to build on windows. I tried to use MediaSession (which is supposed to show notifications), but windows is still confused .-.