Inherit Jekyll's rubocop config for consistency #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathawks
approved these changes
Aug 25, 2017
pathawks
requested changes
Aug 25, 2017
lib/jekyll-gist/gist_tag.rb
Outdated
| [matched[1].strip, matched[2].strip] if matched && matched.length >= 3 | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def context_contains_key?(context, key) | ||
| if context.respond_to?(:has_key?) | ||
| context.has_key?(key) |
There was a problem hiding this comment.
Nope. Look at the context; this needs to be has_key
There was a problem hiding this comment.
Thanks @pathawks, I kinda suspected this, but script/cibuilddidn't fail locally.
pathawks
approved these changes
Aug 25, 2017
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of adding
inherit_gem:\n jekyll: .rubocop.ymlto.rubocop.ymland runningrubocop -aso that this project follows Jekyll core's coding styles for consistency like other core plugins. This way, as Jekyll's Ruby style changes, so too will this project's.