.htaccess is left out when copying static files

[agorf]

It's because of the glob pattern used in read_directories() that does not take into account hidden files. The suggested pattern in the relevant commit does.

[jnrbsn]

I've run into problems in the past using .* in a glob pattern, because it includes . and .. which are generally not desired.

[agorf]

This is what the glob pattern is supposed to return among other things. It's the programmer's job to reject everything they don't want. :-)

But even if you look at the source, this is taken care of by filter_entries() which excludes everything starting with . among other things.

[jnrbsn]

I'm not going to pretend to have looked through every bit of code involved here, but based on my understanding of your response, I get the impression that we're talking about two different things. To clarify, I was not referring to items starting with a dot, but instead, a single dot and a double dot which represent the directory itself and its parent directory, respectively, on Unix-style file systems. My concern was that, if these were included, it might create an undesirable circular reference of some sort. If this is how you understood my comment, then I apologize for my repetition.

I'm also somewhat confused. When you say it's the "programmer's job", are you referring to the person building a Jekyll site or the person writing Jekyll itself? Also, if filter_entries() "excludes everything starting with . among other things" like you say, then how would passing it those items, like in your commit, have any effect?

[agorf]

All your questions will be answered if you look at the source. :-) Sorry if I have been vague, I was assuming you had already done it.

Regarding your first paragraph, you are correct, this is how I understood your comment. If you exclude everything starting with a dot, you also exclude . and ...

Regarding your second question, filter_entries() has an unless statement which checks for .htaccess and does not exclude it. So the end result is everything starting with a . gets excluded, apart from .htaccess, which is the desired behaviour.

When I say "programmer's job" I'm referring to the person building the platform (i.e. Jekyll), not the site. IMO, just because .* returns . and .. (which it should) and people make mistakes with it (by forgetting to exclude them), is not a good enough reason not to use it. With great power, comes great responsibility; a language should not restrict the programmer from mistakes like this.

[sumbach]

Is this a duplicate of #363?

[agorf]

Seems to be!