-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: fix validation errors. #5118
Conversation
@@ -1,4 +1,4 @@ | |||
<footer role="contentinfo"> | |||
<footer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added these in #3256 – should we modify the validation to accept them, or are they no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a bug in the validator back then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying then that this is not a valid attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's redundant. You can always run the validator against the live site
to see the warning.
Ideally you should have the vnu checker but I'm not sure there is a gem nor
can I help integrating...
On Jul 21, 2016 01:17, "Parker Moore" [email protected] wrote:
In site/_includes/footer.html
#5118 (comment):@@ -1,4 +1,4 @@
-
+Are you saying then that this is not a valid attribute?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jekyll/jekyll/pull/5118/files/b6044aebd610d2cce521ef81256703e839d9b19d#r71616819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtcUCe21zSEorYfTgUl9mw2TOtfM3ks5qXp5ogaJpZM4JPZ_0
.
|
@pathawks: thanks. I commented there, we'll see how it goes. |
LGTM. |
@jekyllbot: merge +site |
Only issue left is
Does anyone know where
http-equiv
comes from?