Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: fix validation errors. #5118

Merged
merged 1 commit into from
Jul 21, 2016
Merged

site: fix validation errors. #5118

merged 1 commit into from
Jul 21, 2016

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jul 19, 2016

Only issue left is

Error: A document must not include both a meta element with an http-equiv attribute whose value is content-type, and a meta element with a charset attribute.

Does anyone know where http-equiv comes from?

@@ -1,4 +1,4 @@
<footer role="contentinfo">
<footer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added these in #3256 – should we modify the validation to accept them, or are they no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a bug in the validator back then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying then that this is not a valid attribute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's redundant. You can always run the validator against the live site
to see the warning.

Ideally you should have the vnu checker but I'm not sure there is a gem nor
can I help integrating...

On Jul 21, 2016 01:17, "Parker Moore" [email protected] wrote:

In site/_includes/footer.html
#5118 (comment):

@@ -1,4 +1,4 @@
-


+

Are you saying then that this is not a valid attribute?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jekyll/jekyll/pull/5118/files/b6044aebd610d2cce521ef81256703e839d9b19d#r71616819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVVtcUCe21zSEorYfTgUl9mw2TOtfM3ks5qXp5ogaJpZM4JPZ_0
.

@pathawks
Copy link
Member

Does anyone know where http-equiv comes from?

sparklemotion/nokogiri#1008

@XhmikosR
Copy link
Contributor Author

@pathawks: thanks. I commented there, we'll see how it goes.

@parkr
Copy link
Member

parkr commented Jul 20, 2016

LGTM.

@parkr
Copy link
Member

parkr commented Jul 21, 2016

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit e5028d5 into jekyll:master Jul 21, 2016
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants