Upgrade to Rouge 3 #6381
Merged
Upgrade to Rouge 3 #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathawks
approved these changes
Sep 23, 2017
|
It might be nice to release this fairly soon, but the v3.7.0 milestone looks a bit heavy. I wonder if we could just pick some low hanging fruit? |
ghost
approved these changes
Sep 23, 2017
|
@jekyllbot: merge +minor |
|
@pathawks is this important enough to bump up the priority of releasing a new jekyll version? it just seems to change some internal things and remove support for ruby 1.9 (unless i'm missing something) |
|
If there is some bugfix or something in Rouge 3.0.1 or Rouge 3.1.0, I wouldn't want Jekyll users to be unable to update. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rouge got recently updated to v3.0.
The major version bump is due to rouge-ruby/rouge#763 but doesn't impact our test suite.