Backport #9522 for v4.3.x: Add csv to runtime dependency list #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
added
the
⏪ backport
ashmaroli
changed the title
|
Hello @mathbruyen The Once the relevant changes are backported from |
|
Fixes #9741. |
Merge pull request 9522
mathbruyen
force-pushed
the
ruby-3.4-csv-backport
branch
from
9f77a74 to
0ec4d8c
Compare
|
Hello @ashmaroli any update on when the this will be resolved ? |
|
@cocallaw, I'm currently waiting for |
|
Yeah, this is the pr for the cucumber package cucumber/cucumber-ruby#1771 |
|
Actually, the concerned pull request is cucumber/cucumber-ruby#1773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports 25fd87c to 4.3-stable
Context
Jekyll 4.3.4 fails to run on ruby 3.4 because
csvdependency was removed from stdlib. Cherry-picked #9522 into4.3-stable.This is not sufficient to get Jekyll to work on 3.4, liquid requires bigdecimal and safe_yaml requires base64.
safe_yamlhas not been released in the last 5 years, I don't know if it is still maintained. If not maybeSafeYAML.loadcan be replaced byYAML.safe_load.