Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a race condition in VAAPI CSC to YUV420P #527

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

nyanmisaka
Copy link
Member

@nyanmisaka nyanmisaka commented Jan 19, 2025

Changes

  • Fix a race condition in VAAPI CSC to YUV420P
    There is a race condition for AV_PIX_FMT_YUV420P when mapping from pix_fmt
    to fourcc, both VA_FOURCC_I420 and VA_FOURCC_YV12 could be found by pix_fmt.
    
    fixes "-vf scale_vaapi=format=yuv420p"
    
  • Sync fixes from ffmpeg-rockchip
    * refine hw_device_ctx validation
    * enable some YUVJ formats.
    
  • Update dependencies
  • Bump version to 7.0.2-9

@nyanmisaka nyanmisaka force-pushed the fix-vaapi-csc-i420 branch 2 times, most recently from dc68a31 to 4d2c670 Compare January 19, 2025 15:50
@gnattu
Copy link
Member

gnattu commented Jan 19, 2025

libx265 introduced a regression in commit https://bitbucket.org/multicoreware/x265_git/commits/f5e4a648727ea86828df236eb44742fe3e3bf366#Lsource/common/x86/cpu-a.asmT181

It assumes that all Unix64 targets are Linux-like, using ELF binaries which have ..plt (Procedure Linkage Table). This assumption is invalid for Mach-O binaries, which macOS uses, and causing compiler errors.

@nyanmisaka
Copy link
Member Author

libx265 introduced a regression in commit https://bitbucket.org/multicoreware/x265_git/commits/f5e4a648727ea86828df236eb44742fe3e3bf366#Lsource/common/x86/cpu-a.asmT181

It assumes that all Unix64 targets are Linux-like, using ELF binaries which have ..plt (Procedure Linkage Table). This assumption is invalid for Mach-O binaries, which macOS uses, and causing compiler errors.

Good catch. I think we should stay on 4.1 stable for now.

@nyanmisaka nyanmisaka force-pushed the fix-vaapi-csc-i420 branch 5 times, most recently from 7aff546 to 14d5aca Compare January 19, 2025 19:05
* refine hw_device_ctx validation
* enable some YUVJ formats.

Signed-off-by: nyanmisaka <[email protected]>
Signed-off-by: nyanmisaka <[email protected]>
Signed-off-by: nyanmisaka <[email protected]>
@nyanmisaka nyanmisaka merged commit 5222ba3 into jellyfin:jellyfin Jan 21, 2025
27 checks passed
@nyanmisaka nyanmisaka deleted the fix-vaapi-csc-i420 branch January 21, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants