Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: fallback to internal entropy #531

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Feb 1, 2025

Changes

This adds a patch to fallback to use the internal entropy in libxml2 instead of just abort when the system's own getentropy call failed. The patch should work for both Windows and Linux, on macOS we are using the macOS native libxml implementation which should be not affected by this.

The ubuntu focal build and msys2 Windows Clang build also uses an old version that does not use system entropy generator which is also not affected.

Issues

Fixes #530

@gnattu gnattu requested a review from a team February 1, 2025 06:37
@nyanmisaka
Copy link
Member

I think it might be cleaner to patch it this way?
for v2.13.5: 0001-dict-Fallback-to-internal-entropy.patch
for master: 0001-dict-Fallback-to-internal-entropy-master.patch

This is a fairly trivial fix and we should submit it upstream.

@nyanmisaka
Copy link
Member

This is a fairly trivial fix and we should submit it upstream.

Somehow I cannot fork on their selfhosted gitlab instance...

@nyanmisaka nyanmisaka merged commit 9ce0bcc into jellyfin Feb 1, 2025
27 checks passed
@nyanmisaka nyanmisaka deleted the libxml2-fallback branch February 1, 2025 15:23
@gnattu
Copy link
Member Author

gnattu commented Feb 1, 2025

This is a fairly trivial fix and we should submit it upstream.

Somehow I cannot fork on their selfhosted gitlab instance...

It seems like upstream has no interest in such use case:
https://gitlab.gnome.org/GNOME/libxml2/-/issues/854#note_2337204

@nyanmisaka
Copy link
Member

It seems like upstream has no interest in such use case: https://gitlab.gnome.org/GNOME/libxml2/-/issues/854#note_2337204

You didn't link to the error log, and that maintainer doesn't seem to understand what you're talking about. Better tell him that libxml2 and its caller will simply crash when the Linux kernel doesn't have PRNG support.

Anyway, when Debian upgrades theirs to 2.13+, they may receive more bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFmpeg transcoding crashes on libxml2 call
2 participants