use a 'keydown' listener in video/index.js instead

jellyfin · Jul 10, 2024 · 5ef0428 · 5ef0428
1 parent e28b557
commit 5ef0428
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js
@@ -1775,8 +1775,13 @@ export default function (view) {
         }
     });
 
-    nowPlayingPositionSlider.addEventListener('playpause', function () {
-        playbackManager.playPause(currentPlayer);
+    nowPlayingPositionSlider.addEventListener('keydown', function (e) {
+        if (e.defaultPrevented) return;
+
+        const key = keyboardnavigation.getKeyName(e);
+        if (key === 'Enter') {
+            playbackManager.playPause(currentPlayer);
+        }
     });
 
     nowPlayingPositionSlider.updateBubbleHtml = function(bubble, value) {

diff --git a/src/elements/emby-slider/emby-slider.js b/src/elements/emby-slider/emby-slider.js
@@ -521,19 +521,6 @@ function stepKeyboard(elem, delta) {
     elem.dispatchEvent(event);
 }
 
-/**
-     * Play or pause video.
-     *
-     * @param {Object} elem slider itself
-     */
-function playPauseKeyboard(elem) {
-    const event = new Event('playpause', {
-        bubbles: true,
-        cancelable: false
-    });
-    elem.dispatchEvent(event);
-}
-
 /**
      * Handle KeyDown event
      */
@@ -554,11 +541,9 @@ function onKeyDown(e) {
         case 'Enter':
             if (this.keyboardDragging) {
                 finishKeyboardDragging(this);
-            } else {
-                playPauseKeyboard(this);
+                e.preventDefault();
+                e.stopPropagation();
             }
-            e.preventDefault();
-            e.stopPropagation();
             break;
     }
 }