Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the photo slideshow #915

Closed
heyhippari opened this issue Mar 9, 2020 · 0 comments · Fixed by #967
Closed

Rewrite the photo slideshow #915

heyhippari opened this issue Mar 9, 2020 · 0 comments · Fixed by #967
Labels
enhancement Improve existing functionality or small fixes
Milestone
Release 10.6.0

Comments

@heyhippari
Copy link
Contributor

slideshow.js is currently really badly designed.

  1. It doesn't handle preloading (Despite Swiper supporting it)
  2. It doesn't handle zoom (See [Feature Request] Zoom In on Photos #857)
  3. It doesn't load the full image but loads a reduced version of it

Let's rewrite this completely.
@heyhippari heyhippari added the bug Something isn't working label Mar 9, 2020
@heyhippari heyhippari added this to the Release 10.6.0 milestone Mar 9, 2020
@heyhippari heyhippari added enhancement Improve existing functionality or small fixes and removed bug Something isn't working labels Mar 11, 2020
@heyhippari heyhippari mentioned this issue Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
Release 10.6.0
Development

Successfully merging a pull request may close this issue.

Refactor slideshow.js heyhippari/jellyfin-web
1 participant
@heyhippari