-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor slideshow.js #967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TV layout, left/right keys move focus and switch slides simultaneously.
Not related
Dialogs are broken when you use browser's Back
. After switch to new page.js
, dialogs do not use history
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO
c4ce9b4
to
6c06200
Compare
6c06200
to
88bc6d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loop is somehow works, but first slide moves from left to right.
Edit:
in autoplay mode only
I know this has been closed issue. However, during the refactoring of the code we forgot to do one important thing. Give end User ability to change slideshow timing. Its currently 3000ms. This is way, way too short. Can we make it User programable? Part fo the settings or config? This is way overdue. |
Changes
Refactors slideshow.js to use standard features of Swiper where applicable.
As a result of using virtual slides, looping had to be disabled.
Issues
Fixes #915
Fixes #918