Change webcomponents to non-minified version #1
Conversation
JustAMan
force-pushed
the
deuglify_webcomponents
branch
from
a246acd to
500cfe2
Compare
There was a problem hiding this comment.
I didn't go over every line of code but it looks like nothing has changed besides the minification. There are a lot of css properties that might need to be added back in for older browsers like the webkit fields but I can't say for sure. I believe there is a webpack plugin to add css support for older browsers that might add these in.
There was a problem hiding this comment.
Didn't go through unminification commit - too many changes, and we had already taken previous Emby version for granted, this one is no different - just take what is there and fix bugs when they're found.
Other comments should probably be addressed in separate PRs.
| serverId: serverId, | ||
| syncDialog.showMenu({ | ||
| items: [item], | ||
| serverId: serverId, |
There was a problem hiding this comment.
this messes up indentation
| serverId: serverId, | ||
| syncDialog.showMenu({ | ||
| items: [item], | ||
| serverId: serverId, |
| serverId: serverId, | ||
| syncDialog.showMenu({ | ||
| items: [item], | ||
| serverId: serverId, |
| @@ -281,7 +254,7 @@ | |||
|
|
|||
| function showOverLimitAlert() { | |||
|
|
|||
There was a problem hiding this comment.
This should eventually be cleaned up, for now a TODO should suffice.
Same for similar changes below.
| @@ -2,7 +2,7 @@ define(function () { | |||
| 'use strict'; | |||
|
|
|||
| // hack to work around the server's auto-redirection feature | |||
| var addRedirectPrevention = self.dashboardVersion != null && self.Dashboard && !self.Dashboard.isConnectMode(); | |||
| var addRedirectPrevention = self.dashboardVersion != null && self.Dashboard && !self.AppInfo.isNativeApp; | |||
There was a problem hiding this comment.
This looks strange, should probably be checking for self.AppInfo instead of self.Dashboard and self.dashboardVersion.
What was the point of this change anyway?..
There was a problem hiding this comment.
The function isConnectMode was removed recently and I can confirm isNativeApp is the best solution for now. It was part of the connect removal, but I can't comment on why it checks the value here.
There was a problem hiding this comment.
In this case we don't need the checks for self.dashboardVersion and self.Dashboard, right?
There was a problem hiding this comment.
I would think so, not 100% sure though.
| background-size: 100% 100%; | ||
| .backgroundContainer, | ||
| .dialog { | ||
| background: url(https://github.com/MediaBrowser/Emby.Resources/raw/master/images/wallpaper/atv1-1080.png) center center no-repeat #D5E9F2; |
src/bower_components/emby-webcomponents/themes/blueradiance/theme.css
Outdated
Show resolved
Hide resolved
src/bower_components/emby-webcomponents/themes/dark-green/theme.css
Outdated
Show resolved
Hide resolved
src/bower_components/emby-webcomponents/themes/dark-red/theme.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This might need a linter to go over it automatically to fix some of that indenting. But I think it's good to go in. We can put out fires as they show up.
This will need autoprefixer in for example webpack with a correct browser list to add all those prefixes back. But adding that build is for another PR.
|
@EraYaN can you please make this webpack thing happen then? |
|
I'll give it a shot this weekend. I'll make an issue and self assign. |
|
I'm marking as resolved my questions regarding no-prefix stuff to make this cleaner to view. |
I used
git diff 7579d6c 280f1e9 MediaBrowser.WebDashboard/dashboard-ui/bower_components/emby-webcomponents/in the main repo to find all changes related to emby-components done before this PR.Please make sure that I didn't miss something. This is a re-implementation of jellyfin/jellyfin#341.
Edit by @JustAMan: I have split the original PR in two commits - one is plain unminification using 1.5.323 from emby-webcomponents, other is applying our fixes on top of that.