Add Lyrics Editor for Admin users only #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
feature
|
thornbill
reviewed
Jul 15, 2024
|
@scampower3 do you think there is a way we could limit some of the code duplication between this and the subtitle editor? |
|
@thornbill I don't think so. The highlighted duplicates by sonarcloud are mostly the event handlers and its associated logic. |
thornbill
requested changes
Aug 17, 2024
thornbill
reviewed
Aug 20, 2024
thornbill
reviewed
Aug 20, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Bill Thornton <[email protected]>
Co-authored-by: Bill Thornton <[email protected]>
Co-authored-by: Bill Thornton <[email protected]>
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lyrics editor dialog so that admin users can manually add, remove or search for lyrics through the web ui. Code is based on the subtitle editor.
Search has been tested using the LrcLib plugin
Changes
Issues