Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to reset metadata in metadata editor #5604

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

scampower3
Copy link
Member

Changes

Adds a button to reset metadata inputs in the metadata editor.
https://features.jellyfin.org/posts/2235/an-option-to-reset-mis-populated-metadata
Issues

@scampower3 scampower3 added the enhancement Improve existing functionality or small fixes label May 25, 2024
@scampower3 scampower3 requested a review from a team as a code owner May 25, 2024 06:05
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -264,6 +264,9 @@ <h2>${HeaderMetadataSettings}</h2>
<button is="emby-button" type="button" class="raised button-cancel block btnCancel formDialogFooterItem">
<span>${ButtonCancel}</span>
</button>
<button is="emby-button" type="button" class="raised button-reset block btnReset formDialogFooterItem">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if should be in a diff colour than the other 2 btns.

@scampower3 scampower3 added this to the v10.10.0 milestone May 25, 2024
@TimGels
Copy link
Member

TimGels commented May 26, 2024

I am a bit conflicted with this. Such button is rarely used, if I were to guess. And showing the button prominent alongside Save and Cancel could be a UX downside. Most people don't have a need to clear all metadata fields at once, and this could cause for irritation when they accidentally click on "Reset" instead of "Save" after manually editing fields. At the same time, this is also true for "Cancel", so I am not sure how much I overthink this. But I can see the usefulness when wrong metadata is filled (although a new re-scan will just fill the fields with new metadata).

@scampower3
Copy link
Member Author

scampower3 commented May 26, 2024

Such button is rarely used, if I were to guess.

I agree that this button is probably going to be infrequently used. Jellyfin does a pretty good job at identifying correctly.

showing the button prominent alongside Save and Cancel could be a UX downside

Probably. Could move it onto a less prominent location too.

But I can see the usefulness when wrong metadata is filled

Right. The main case for this button is when wrong metadata is filled. Sometimes, it can be easier to just refill the entire metadata form, instead of checking and editing each field individually, especially if there is a large amount of metadata to be edited. I think the metadata editor form has enough input fields to justify a dedicated button to reset the form.

@thornbill thornbill added the ui & ux This PR or issue mainly concerns UI & UX label Jun 9, 2024
@thornbill
Copy link
Member

Let's post a screenshot of this in the ui/ux matrix room and request some feedback from Erik

@thornbill
Copy link
Member

@jellyfin-bot rebase

Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now. The metadata editor needs a UI/UX overhaul at some point anyway.

Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 3b7d159749716a7965f5b8a8f85111311f4dc034
Status ✅ Deployed!
Preview URL https://0a982a2a.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 9c2b6d5 into jellyfin:master Aug 27, 2024
12 checks passed
@scampower3 scampower3 deleted the reset-metadata branch October 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants