-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to reset metadata in metadata editor #5604
Conversation
Quality Gate passedIssues Measures |
@@ -264,6 +264,9 @@ <h2>${HeaderMetadataSettings}</h2> | |||
<button is="emby-button" type="button" class="raised button-cancel block btnCancel formDialogFooterItem"> | |||
<span>${ButtonCancel}</span> | |||
</button> | |||
<button is="emby-button" type="button" class="raised button-reset block btnReset formDialogFooterItem"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if should be in a diff colour than the other 2 btns.
I am a bit conflicted with this. Such button is rarely used, if I were to guess. And showing the button prominent alongside Save and Cancel could be a UX downside. Most people don't have a need to clear all metadata fields at once, and this could cause for irritation when they accidentally click on "Reset" instead of "Save" after manually editing fields. At the same time, this is also true for "Cancel", so I am not sure how much I overthink this. But I can see the usefulness when wrong metadata is filled (although a new re-scan will just fill the fields with new metadata). |
I agree that this button is probably going to be infrequently used. Jellyfin does a pretty good job at identifying correctly.
Probably. Could move it onto a less prominent location too.
Right. The main case for this button is when wrong metadata is filled. Sometimes, it can be easier to just refill the entire metadata form, instead of checking and editing each field individually, especially if there is a large amount of metadata to be edited. I think the metadata editor form has enough input fields to justify a dedicated button to reset the form. |
Let's post a screenshot of this in the ui/ux matrix room and request some feedback from Erik |
@jellyfin-bot rebase |
5351ed9
to
4c7a77c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now. The metadata editor needs a UI/UX overhaul at some point anyway.
Quality Gate passedIssues Measures |
Cloudflare Pages deployment
|
Changes
Adds a button to reset metadata inputs in the metadata editor.
https://features.jellyfin.org/posts/2235/an-option-to-reset-mis-populated-metadata
Issues