Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swipe gestures on android for book reader #5843

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

viown
Copy link
Member

@viown viown commented Jul 27, 2024

Fixes swipe gestures not working on android.

Changes
Changes the swipe gestures to use the element loaded by epubjs which seems to fix this issue.

Issues
Fixes #5830

@viown viown requested a review from a team as a code owner July 27, 2024 18:50
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/plugins/bookPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/bookPlayer/plugin.js Outdated Show resolved Hide resolved
Copy link

@thornbill thornbill added this to the v10.9.10 milestone Aug 9, 2024
@thornbill thornbill added bug Something isn't working regression We broke something stable backport Backport into the next stable release needs testing This PR requires additional testing labels Aug 9, 2024
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works on iOS in my testing

@thornbill thornbill merged commit 44afbc2 into jellyfin:release-10.9.z Aug 13, 2024
11 checks passed
@thornbill thornbill removed the needs testing This PR requires additional testing label Aug 13, 2024
thornbill pushed a commit that referenced this pull request Aug 13, 2024
Fix swipe gestures on android for book reader

Original-merge: 44afbc2

Merged-by: thornbill <[email protected]>

Backported-by: thornbill <[email protected]>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Aug 13, 2024
@viown viown deleted the fix-android-swipe-gesture branch August 29, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants