Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override mp3 remux container #5914

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Aug 15, 2024

The server generally filters out invalid containers for HLS in most cases. However, MP3 is a special case because, while it is technically possible and allowed as a codec for fMP4 on the server side, most browsers do not support it. Override the remux container to force MPEG-TS for MP3. The server will still direct play MP3 in an MP3 container. This is useful for supporting universal containers like MKA.

Changes

  • Override the remuxing container to mpegts for mp3

Issues

The server generally filters out invalid containers for HLS in most cases. However, MP3 is a special case because, while it is technically possible and allowed as a codec for fMP4 on the server side, most browsers do not support it. Override the remux container to force MPEG-TS for MP3. The server will still direct play MP3 in an MP3 container. This is useful for supporting universal containers like MKA.
@gnattu gnattu requested a review from a team as a code owner August 15, 2024 01:29
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 6b9e1245559e5553e11fda6660f80a223fefb192
Status ✅ Deployed!
Preview URL https://a395c483.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill added enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback labels Aug 17, 2024
@thornbill thornbill added this to the v10.10.0 milestone Aug 17, 2024
@thornbill thornbill merged commit 6e0ad2e into jellyfin:master Aug 17, 2024
12 checks passed
@gnattu gnattu deleted the mp3-remux-override branch August 18, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes playback This PR or issue mainly concerns playback
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants