Fix autocast listener #6036
Merged
Fix autocast listener #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viown
force-pushed
the
fix-autocast-hopefully
branch
from
bd9d25f to
8a08efd
Compare
viown
force-pushed
the
fix-autocast-hopefully
branch
from
8a08efd to
c0cd03a
Compare
|
Rebased to master. Confirmed changes still work as expected. |
thornbill
approved these changes
Sep 20, 2024
thornbill
force-pushed
the
fix-autocast-hopefully
branch
from
c0cd03a to
7b15350
Compare
|
Cloudflare Pages deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging the release version, I noticed that the 'websocketopen' event isn't assigned to the api client when it's triggered:
But it's still triggered after the "initializing connection listener" log message, so I can only assume it's being assigned to the wrong api client.
Changes
Add the websocket event to all api clients and listen for new ones
Issues
May fix #5878