Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playback subscriber callback binding #6172

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix playback subscriber callback binding #6172

merged 1 commit into from
Oct 9, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Fixes playback subscriber callbacks not being bound to the right context
  • Changes player access to protected so implementations can access the player instance

Issues
N/A

@thornbill thornbill added the bug Something isn't working label Oct 8, 2024
@thornbill thornbill added this to the v10.10.0 milestone Oct 8, 2024
@thornbill thornbill requested a review from a team as a code owner October 8, 2024 15:48
@thornbill thornbill force-pushed the fix-playback-subscriber-bind branch from e472fd7 to 49433cd Compare October 8, 2024 16:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 49433cd6402fa0cee666125015ba025497a48ed5
Status ✅ Deployed!
Preview URL https://0fbc3f57.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 6f5c8c8 into jellyfin:master Oct 9, 2024
12 checks passed
@thornbill thornbill deleted the fix-playback-subscriber-bind branch October 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @jellyfin-bot @nielsvanvelzen @dmitrylyzo