Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spinner direction (should be clockwise) in @keyframes spin #6324

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix spinner direction (should be clockwise) in @keyframes spin #6324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/styles/videoosd.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,8 @@
margin-left: auto;
}

@keyframes spin {
Copy link
Contributor

@dmitrylyzo dmitrylyzo Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this one and remove the one below - less changes and the animation is defined before use.

UPD:
Hmm, maybe another one is for SyncPlay indicators? #1945 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all @keyframes are defined at the end of the file.
I'll create two explicite spin animations, one for clockwise, one for counterclockwise, and use each animation in the right class.

100% {
transform: rotate(360deg);
}
}

.osdMediaStatus .animate {
animation: spin 4s linear infinite;
animation: spin-clockwise 4s linear infinite;
}

@media all and (max-width: 30em) {
Expand Down Expand Up @@ -236,7 +230,7 @@

.primary-icon.spin {
font-size: 76px !important;
animation: spin 2s linear infinite;
animation: spin-counterclockwise 2s linear infinite;
}

.secondary-icon {
Expand Down Expand Up @@ -326,8 +320,14 @@
}
}

@keyframes spin {
@keyframes spin-counterclockwise {
100% {
transform: rotate(-360deg);
}
}

@keyframes spin-clockwise {
100% {
transform: rotate(360deg);
}
}
Loading