Add controls for DeinterlaceMethod #968
Conversation
Add controls and US-English text for DeinterlaceMethod in encodingsettings. Uses the values referenced here jellyfin/jellyfin#2639
|
@alset333 is this ready for review? |
|
Yes, @dkanada, this should be ready for review now. The code it depends on was committed at jellyfin/jellyfin@5acd052 |
|
I don't see where |
Indeed, there's no getter or setter for the setting. As-is, it will do nothing but add the nonfunctioning input @alset333 . |
Hm... I'll take another look but it seemed to be working on my end; possible I missed something with the repo. Edit: Aw shucks you're right. Not working locally either. I think I see where I worked on it before and will try to fix. I must've deleted the changes somewhere. |
alset333
changed the title
specify "transcoding interlaced content" instead of just "transcoding" Co-Authored-By: Julien Machiels <[email protected]>
alset333
changed the title
|
I think this is working correctly now. The getters and setters for "selectDeinterlaceMethod" have been added to encodingsettings.js based on the structure of "selectEncoderPreset"'s getters/setters. Now testing good on my end again; surprised I didn't catch this issue myself so thanks. |
| @@ -14,6 +14,7 @@ define(["jQuery", "loading", "globalize", "dom", "libraryMenu"], function ($, lo | |||
| $("#txtVaapiDevice", page).val(config.VaapiDevice || ""); | |||
| page.querySelector("#selectEncoderPreset").value = config.EncoderPreset || ""; | |||
| page.querySelector("#txtH264Crf").value = config.H264Crf || ""; | |||
| page.querySelector("#selectDeinterlaceMethod").value = config.DeinterlaceMethod || ""; | |||
There was a problem hiding this comment.
If config.DeinterlaceMethod is not set, selectDeinterlaceMethod is empty. Should there be a default method?
Edit:
I hacked this a bit - cleared config.DeinterlaceMethod, because it was yadif. So maybe it will never be unset.
There was a problem hiding this comment.
It should always be set, the default server-side value is "yadif" per this code
We could add a default in encodingsettings, but there isn't one for most of the other settings (EncoderPreset, H264Crf, etc) which are already there.
Add controls and US-English text for DeinterlaceMethod in encodingsettings. Uses the values referenced here: jellyfin/jellyfin#2639
Changes